Repository navigation
[CI] lint: Import ForwardMode from its defining module in the KV translate test - #48535
Merged
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
3 of 5 tasks
This was referenced Nov 5, 2026
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Lint is red on main:
check-indirect-importsrejectstest/registered/unit/layers/attention/test_kv_translate_ownership.py:40, which importsForwardModethroughforward_batch_info, a module that only re-imports it. #47632 added the line; its last lint run predates the rule (#47992), so it merged red. Every open PR's lint fails on it.Modifications
Import
ForwardModefromsglang.srt.model_executor.forward_mode, where it is defined.Tests
pre-commitpasses on the file;test_kv_translate_ownership.pypasses (5 tests).CI States
Latest PR Test (Base): ❌ Run #41969505713
Latest PR Test (Extra): ❌ Run #41969505508
Latest PR Test (AMD ROCm 10): ❌ Run #41969505490
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: