Skip to content

[CI] lint: Import ForwardMode from its defining module in the KV translate test - #48535

Merged
hnyls2002 merged 1 commit into
mainfrom
lsyin/fix-forward-mode-import
Nov 5, 2026
Merged

hnyls2002 merged 1 commit into
mainfrom
lsyin/fix-forward-mode-import

Conversation

@hnyls2002

@hnyls2002 hnyls2002 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Lint is red on main: check-indirect-imports rejects test/registered/unit/layers/attention/test_kv_translate_ownership.py:40, which imports ForwardMode through forward_batch_info, a module that only re-imports it. #47632 added the line; its last lint run predates the rule (#47992), so it merged red. Every open PR's lint fails on it.

Modifications

Import ForwardMode from sglang.srt.model_executor.forward_mode, where it is defined.

Tests

pre-commit passes on the file; test_kv_translate_ownership.py passes (5 tests).


CI States

Latest PR Test (Base): ❌ Run #41969505713
Latest PR Test (Extra): ❌ Run #41969505508
Latest PR Test (AMD ROCm 10): ❌ Run #41969505490

Tip

Base CI only covers the core cases, and its workload may not exercise your change. Use /rerun-test to run the tests your change touches, or copy this prompt for an agent:

Find the registered tests this PR affects and run them with /rerun-test, following https://github.com/sgl-project/sglang/blob/main/.agents/skills/rerun-test/SKILL.md

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant