Skip to content

[Fix] self.worker assignment in TpModelWorker and refactor references #4788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

[Fix] self.worker assignment in TpModelWorker and refactor references #4788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4a6d58
fix: assign self.worker in TpModelWorker constructor
JustinTong0323 Mar 26, 2025
eb0f89a
refactor: simplify worker assignment in save_remote_model and save_sh…
JustinTong0323 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions python/sglang/srt/managers/scheduler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1702,18 +1702,12 @@ def handle_rpc_request(self, recv_req: RpcReqInput):
def save_remote_model(self, params):
url = params["url"]

if isinstance(self.tp_worker, TpModelWorkerClient):
worker = self.tp_worker.worker
else:
worker = self.tp_worker
worker = self.tp_worker.worker

worker.model_runner.save_remote_model(url)

def save_sharded_model(self, params):
if isinstance(self.tp_worker, TpModelWorkerClient):
worker = self.tp_worker.worker
else:
worker = self.tp_worker
worker = self.tp_worker.worker

worker.model_runner.save_sharded_model(
path=params["path"],
Expand Down
2 changes: 2 additions & 0 deletions python/sglang/srt/managers/tp_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,8 @@ def __init__(
req_to_token_pool: Optional[ReqToTokenPool] = None,
token_to_kv_pool_allocator: Optional[TokenToKVPoolAllocator] = None,
):
self.worker = self

# Parse args
self.tp_rank = tp_rank

Expand Down
Loading