Repository navigation
[Test] managers: Check output_ids in the router grouping test - #47335
Merged
Merged
Conversation
… only in rust server mode
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Collaborator
Author
|
/rerun-test test_multi_tokenizer_mixin.py |
Contributor
|
🚀 |
Yuxingwang-intel
pushed a commit
to Yuxingwang-intel/sglang
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_multi_tokenizer_mixin.py::test_router_groups_token_output_without_speculative_decodingfails on main withAssertionError: None != [10, 20].#47249 replaced the test's
decoded_textsassertion withprompt_tokens == [10, 20], while #47178 madeBatchTokenIDOutput.prompt_tokensa Rust-server-only column that this fixture no longer sets. Each PR passed on its own; together the assertion readsNone.The assertion now checks
output_ids, another per-row field the fixture sets, so the test still guards that grouping keeps per-row lists intact.CI States
Latest PR Test (Base): ❌ Run #40958650528
Latest PR Test (Extra): ❌ Run #40958650694
Latest PR Test (AMD ROCm 10): ❌ Run #40958650671