Repository navigation
Created by mistake - #47026
Closed
JackChuang wants to merge 1 commit into
Closed
Created by mistake#47026JackChuang wants to merge 1 commit into
JackChuang wants to merge 1 commit into
Conversation
… writer set_mla_kv_buffer_kernel_norope wrote every loc, including the padding slot 0 that the RoPE writers skip since sgl-project#36003. Padding rows can carry NaN K since sgl-project#42689, and the FP8 TileLang sparse decode reads row 0 for unused top-k entries, so models with qk_rope_head_dim = 0 (GLM-5.3-Flash) decoded NaN logits with an FP8 KV cache. Skip the slot in the kernel and in the torch-native fallback, and run the reserved-slot tests with rope_dim = 0.
JackChuang
requested review from
BBuf,
DarkSharpness,
HaiShaw,
HydraQYH,
celve and
yuan-luo
as code owners
October 28, 2026 08:31
JackChuang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by mistake