-
Notifications
You must be signed in to change notification settings - Fork 3.4k
[Feature] use pytest for sgl-kernel #4697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 7 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
31c0096
change
adarshxs 730684c
Update test_trt_allreduce.py
adarshxs c0e788a
fix lint
adarshxs 01d25dd
update
adarshxs b7a906d
fix
adarshxs 9ab22c7
Merge branch 'main' into pytest_transition
adarshxs 4577ca8
Merge branch 'main' into pytest_transition
zhyncs ca587e5
Merge branch 'sgl-project:main' into pytest_transition
adarshxs 454af13
revert test_trt_allreduce
adarshxs 6de95c0
Merge branch 'pytest_transition' of https://github.com/adarshxs/sglan…
adarshxs b1413f1
update spec
adarshxs fa5a6bd
Merge branch 'main' into pytest_transition
zhyncs 533e1cf
Merge branch 'main' into pytest_transition
zhyncs de2a02e
Merge branch 'main' into pytest_transition
zhyncs e4ae252
parameterize
adarshxs bdf950c
upstream
adarshxs b2454e7
Merge branch 'main' into pytest_transition
adarshxs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For different shapes you should use
@pytest.mark.parametrizeinstead of for loop