Repository navigation
[CI] [AMD] minimax-m3.1: Add a MI35x MXFP4 + DSpark nightly accuracy gate - #46944
Draft
michaelzhang-ai wants to merge 2 commits into
Draft
michaelzhang-ai wants to merge 2 commits into
michaelzhang-ai wants to merge 2 commits into
Conversation
…racy test Runs the cookbook's MI355X / Flash / MXFP4 / Low-Latency / DSpark cell (amd/MiniMax-M3.1-Flash-Quark-MXFP4, TP4, bundled DSpark draft) and gates it on full-split sgl-eval GSM8K at 0.93, the same settings and threshold as the H200 and B300 M3.1 nightlies.
…from the measured run
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a MI35x nightly accuracy gate for MiniMax-M3.1-Flash that runs the cookbook's MI355X / Flash / MXFP4 / Low-Latency / single-node / DSpark cell:
test/registered/amd/accuracy/mi35x/test_minimax_m31_flash_mxfp4_eval_mi35x.pynightly-amd-4-gpu-mi35x-minimax-m31-flash-mxfp4nightly-4-gpu-mi35x-minimax-m31-flash-mxfp4onlinux-mi35x-gpu-8(TP4), 5400 s per-file capThe server uses the cookbook command unchanged:
amd/MiniMax-M3.1-Flash-Quark-MXFP4,SGLANG_USE_AITER=1, TP4, DSpark with block verification and the draft bundled in the checkpoint, breakable prefill graphs, the aiter FP8 GEMM backend, and the minimax-m3 parsers. GSM8K runs through sgl-eval on the full split (1319 questions, 8192 max tokens, temperature 1.0, top_p 0.95) with a 0.93 threshold. These match the H200 and B300 M3.1 nightlies in #46627, so all three gates read the same way.Depends on
maintoday the Quark checkpoint has no ROCm path for DSpark or the MXFP4 experts.amd/MiniMax-M3.1-Flash-Quark-MXFP4start with shared-experts fusion left on, as in the cookbook command. Without it the server fails at weight load.This PR stays in draft until those land.
Notes for the reviewer
Test plan
Run on a branch with
mainat ec3365d plus #46693 and #46587 merged in, and this test (michael/minimax-m31-mxfp4-validate). #46587 conflicts with #46693 inquark.py; the branch keeps both changes and enables #46587's E8M0 scale decode only when #46693's MXFP8 path is off.The first rocm10 attempt failed while downloading the checkpoint: the rocm720 job, on another runner sharing the model cache, deleted the in-progress download. That is a CI cache race, not this test.
job_selectoptions and incheck-all-jobs.needs.CI States
Latest PR Test (Base): ❌ Run #40735456071
Latest PR Test (Extra): ❌ Run #40735455771
Latest PR Test (AMD ROCm 10): ❌ Run #40735456069