Repository navigation
[CI] [AMD] deps: Install openai 2.8.0 in AMD CI for the Responses API - #46774
Merged
michaelzhang-ai merged 1 commit intoOct 27, 2026
Merged
Conversation
serving_responses.py now imports responses_tools/beam.py at module level (sgl-project#45254), which needs ResponseFunctionShellToolCall from openai>=2.8.0. AMD CI installs pyproject_other.toml (openai==2.6.1), so the Responses handler fails to import and TestOpenAIServerv1Responses.test_error gets 500 instead of 400. Pin openai 2.8.0 in the AMD CI installer only.
1 task done
5 tasks done
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since #45254,
serving_responses.pyimportsresponses_tools/beam.pyat module level, andbeam.pyusesResponseFunctionShellToolCall, which only exists in openai>=2.8.0. #45291 movedpython/pyproject.tomlto 2.8.0 but leftpyproject_other.tomlat 2.6.1, and AMD CI installs frompyproject_other.toml. On AMD the Responses handler now fails to import at startup:Every
/v1/responsesrequest returns 500.TestOpenAIServerv1Responses.test_errorintest/registered/openai_server/basic/test_openai_server.pyexpects 400, sostage-b-test-1-gpu-small-amdfails on main (example job). The same shard passed on main before #45254 landed.Modifications
scripts/ci/amd/amd_ci_install_dependency.shinstallsopenai==2.8.0after the sglang install. This applies to the AMD CI installer only:pyproject_other.toml, the other platforms that use it, and non-CI installs are unchanged. The step can go oncepyproject_other.tomlmoves to 2.8.0.Test plan
stage-b-test-1-gpu-small-amdon rocm10, dispatched on this commit:test_openai_server.pypasses, 53 tests OK includingTestOpenAIServerv1Responses.test_error(job). Shard 0 of that run lost its self-hosted runner, which is unrelated to this change.CI States
Latest PR Test (Base): ✅ Run #40470472759
Latest PR Test (Extra): ❌ Run #40470472709
Latest PR Test (AMD ROCm 10): ❌ Run #40470472630