Repository navigation
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
aryatsc
requested review from
Alisehen,
AniZpZ,
BBuf,
DarkSharpness,
Edwardf0t1,
FlamingoPg,
Fridge003,
HaiShaw,
HydraQYH,
OrangeRedeng,
Ying1123,
b8zhong,
celve,
ch-wan,
ispobock,
merrymercy and
yuan-luo
as code owners
October 26, 2026 20:04
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # python/sglang/srt/environ.py
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # python/sglang/kernels/ops/moe/moe_sorting_small.py
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # python/sglang/kernels/ops/moe/__init__.py
This comment has been minimized.
This comment has been minimized.
…erCore.run Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
K3's attention-residual aggregation ran as a separate all-reduce plus aggregation kernels per layer.
Modifications
attn_res_smallm,ar_agg_hipandag_one_barrier_hipfuse the aggregation into the TP all-reduce / all-gather with one barrier.all_gather_lastdim_addfrom [HIP] Addall_gather_lastdim_addto the custom all-reduce ROCm/aiter#6960.Accuracy Tests
test_attn_res.pyandtest_attn_res_mix_large_tokens.pypass on MI355. This PR adds no new test.Full K3 stack on MI355X TP8 (DFlash, prod config) vs B300, McNemar:
Speed Tests and Profiling
Throughput change from turning this feature off on the full stack: -2.7/-1.1/-3.4% on the agentic replay at C=1/8/32, and -6.3/-2.2% at 90k prefix at C=1/8 (mean -3.1%).
Dependencies
all_gather_lastdim_addto the custom all-reduce ROCm/aiter#6960.Checklist
CI States
Latest PR Test (Base): ❌ Run #42125653195
Latest PR Test (Extra): ❌ Run #42125652668
Latest PR Test (AMD ROCm 10): ❌ Run #42125652934
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: