Repository navigation
Conversation
feng397
requested review from
Fridge003,
HaiShaw,
Qiaolin-Yu,
Ying1123,
hebiao064,
hnyls2002,
ispobock and
merrymercy
as code owners
October 26, 2026 16:06
Collaborator
|
Thanks @feng397! You tracked down the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DeepSeek V4/4.1 DSpark draft metadata preparation falls back to
seq_lens.tolist()when the batch has no CPU sequence-length mirror. This is the normal CUDA DSpark draft path. Since #45450 enables the eligible draft runner's metadata glue graph by default, its capture reaches a device-to-host read and fails:The existing fallback continues preparing metadata eagerly, but permanently loses the glue optimization for that runner instance.
Modifications
seq_lens.shape[0], and allow the extended CPU-length mirror to remain absent through the metadata preparation interfaces.Accuracy Tests
(batch size, block size)cases(1, 3),(2, 3), and(1, 6), with two graph replays per case after warm-up/capture. Updated causal lengths, positions, page tables, SWA indices, and SWA lengths match eager preparation. These checks use the real causal/page/SWA metadata kernels and synthetic KV mappings in a separate test process.flashmla_mega. After restarting with the patch, both workers are healthy and their logs contain zero metadata glue capture failures and zero tracebacks during the check.git diff --check.Checklist
CI States
Latest PR Test (Base): ❌ Run #40440631650
Latest PR Test (Extra): ❌ Run #40440631535
Latest PR Test (AMD ROCm 10): ❌ Run #40440631478