Skip to content

Remove Unintended Capture Batch Sizes in AMD HIP Graph Runner #4638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025
Merged

Remove Unintended Capture Batch Sizes in AMD HIP Graph Runner #4638

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
184a750
remove unintended capture bs in HIP
gmlwns2000 Mar 20, 2025
d438dc2
Merge branch 'sgl-project:main' into feat/unintended-bs
gmlwns2000 Mar 23, 2025
88faf4c
Merge branch 'main' into feat/unintended-bs
gmlwns2000 Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/sglang/srt/model_executor/cuda_graph_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ def get_batch_sizes_to_capture(model_runner: ModelRunner):
# capture less.
capture_bs = list(range(1, 9)) + list(range(9, 33, 2)) + [64, 96, 128, 160]

if _is_hip:
capture_bs += [i * 8 for i in range(21, 33)]
if _is_hip:
capture_bs += [i * 8 for i in range(21, 33)]

if max(capture_bs) > model_runner.req_to_token_pool.size:
# In some case (e.g., with a small GPU or --max-running-requests), the #max-running-requests
Expand Down
Loading