Skip to content

remove unused function that may cause exception - #4603

Closed
tianyuzhou95 wants to merge 2 commits into
sgl-project:mainfrom
tianyuzhou95:albert/cleanup
Closed

tianyuzhou95 wants to merge 2 commits into
sgl-project:mainfrom
tianyuzhou95:albert/cleanup

Conversation

@tianyuzhou95

Copy link
Copy Markdown
Contributor

This patch removes the member function is_prefill of the class ForwardMode, as it is not used and references an undefined value PREFILL (which was removed in commit c76040e).

This patch removes the member function is_prefill of the class
ForwardMode, as it is not used and references an undefined value
PREFILL (which was removed in commit c76040e).

Signed-off-by: Tianyu Zhou <albert.zty@antgroup.com>
@merrymercy merrymercy added the ready-to-merge The PR is ready to merge after the CI is green. label Apr 21, 2025
@merrymercy merrymercy closed this Apr 27, 2025
@merrymercy

Copy link
Copy Markdown
Collaborator

fixed in the main

nvpohanh added a commit to nvpohanh/sglang that referenced this pull request Nov 2, 2026
…in c5e8b9b3

Mirror the SemiAnalysis InferenceX AgentX SGLang / Dynamo+SGLang lanes at
InferenceX main c5e8b9b3 (MiniMax-M3.1-Flash GB300 SGLang and Dynamo+SGLang
from InferenceX sgl-project#4676 / sgl-project#4698, DeepSeek-V4.1-Flash GB300 Dynamo+SGLang from
sgl-project#4595, now from their dashboard runs), with InferenceX PRs sgl-project#4726
(MiniMax-M3.1-Flash B300), sgl-project#4695 (MiniMax-M3.1-Flash GB200 Dynamo+SGLang),
sgl-project#4725 sgl-project#4724 sgl-project#4707 sgl-project#4670 (Muse Spark Open B300 / GB300 / B200 / GB200),
sgl-project#4683 (Qwen3.8-Flash-Next B300 NVFP4, /use run 41117066222) and sgl-project#4603
(DeepSeek-V4.1-Flash GB300) overlaid. This replaces the MiniMax data
that sgl-project#47623, sgl-project#47699 and sgl-project#47791 edited by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge The PR is ready to merge after the CI is green.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants