Repository navigation
[Fix] diffusion: Drop stale mismatch_msg from FLUX 3 video VAE gate call - #45778
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
alexnails
requested review from
AgainstEntropy,
BBuf,
HaiShaw,
kevin-mii,
mickqian,
niehen6174,
ping1jing2 and
yichiche
as code owners
October 22, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#41894 calls
BitExactFusionGate.accept_or_fallback(..., mismatch_msg=...), but #44690 removed that keyword from the gate and every other caller. The first fused QKV norm+RoPE call in the FLUX 3 video VAE raisesTypeError: unexpected keyword argument 'mismatch_msg'. This is the remaining break after #45775.Modifications
Drop the keyword.
Tests
test/registered/kernels/ops/diffusion/test_flux3_video_qknorm_rope.pyon H200:test_natten_prepare_qkv_matches_eager_and_reuses_rope_cachefails with theTypeErrorwith #45775 alone; all 4 pass with this change.🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #39748250854
Latest PR Test (Extra): ❌ Run #39748250779
Latest PR Test (AMD ROCm 10): ❌ Run #39748250778