Repository navigation
[Perf] [AMD] rccl: upgrade rccl to 2.32.3 for rocm10.1 - #45576
Merged
Merged
Conversation
This reverts commit b08dc8b.
This reverts commit 5b1cda0.
yctseng0211
marked this pull request as ready for review
October 27, 2026 10:43
yctseng0211
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock and
sogalin
as code owners
October 27, 2026 10:43
sogalin
approved these changes
Oct 27, 2026
sogalin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, specific for ROCm10.1
This was referenced Oct 27, 2026
1 of 3 tasks
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MAXBLOCKS=64MAXBLOCKS=642.30.7-HEAD:7da4302) uses a fixed 256 DDA fabric blocks. Capping at 64 gives +5.2% throughput, -9.3% median ITL and -22% p99 ITL.4ca8623) defaults to 96 blocks here. That alone gives the best throughput (+6.7%) and TTFT (-5.0%) and -6.3% median ITL, but p99 ITL improves by only 8.4%. The first run in the fresh container was discarded as JIT warm-up.MAXBLOCKS=64still trades about 4% TTFT for -15% p99 ITL and -2.5% median ITL; throughput is flat.MAXBLOCKS=64makes no difference (all metrics within +/-0.4%).Background (4GPUs)
We first found this regression with RCCL 2.30.7. At conc=64 (8192 in / 1024 out), median ITL went from 40.59 ms on stock 2.30.4 to 50.85 ms (+25%), although throughput improved by 6.8%. That 2.30.7 was built by us from rocm-systems @
44704e4against the ROCm 10 SDK inrocm/sgl-dev:v0.5.19-rocm10-mi45x-20260913. Root cause:RCCL_DDA_FABRIC_MAXBLOCKSdefaults to 192, so the DDA fabric barrier issues 768 flag writes per all-reduce (96 on 2.30.4). Capping it at 64 brought median ITL to 38.63 ms (-4.8% vs stock) and throughput to +20.4% vs stock.Modifications
Pin rccl to 1c0ab425abda9d1fd80fa977c253556b14eb140b
ROCm/rocm-systems#14254 fixes the random hang issue. The current image is built from that PR's head; we will rebuild from main once the PR is merged.
Accuracy Tests
Speed Tests and Profiling
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #40494526127
Latest PR Test (Extra): ❌ Run #40494526148
Latest PR Test (AMD ROCm 10): ❌ Run #40494526163