Repository navigation
[Perf] dspark: Make the prefill SWA valid-from update sync-free - #45234
Merged
Merged
Conversation
hnyls2002
requested review from
Qiaolin-Yu,
Ying1123 and
merrymercy
as code owners
October 19, 2026 21:23
Collaborator
Author
|
/rerun-test test_deepseek_v41_flash_gb300_encoder_bcg.py test_dsv4_compressed_pools.py test_encoder_swa_replay.py |
Collaborator
Author
|
/tag-and-rerun-ci |
Contributor
|
🚀 🚀 |
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSparkWorkerV2._forward_prefillmarks each newly placed request's draft SWA ring valid from its cached prefix. It built the slots by indexing a CUDA tensor with a Python list and the prefix lengths withtorch.tensor(..., device=...). Both are pageable host-to-device copies that block the host. They run after the target forward is enqueued, so each prefill step stalled the scheduler until the whole target forward finished.async_h2d(pinned, non-blocking), and the slots come from anindex_selecton the device. No behavior change: same slots, same values.CI States
Latest PR Test (Base): 🚫 Run #39327514044
Latest PR Test (Extra): ❌ Run #39327515096
Latest PR Test (AMD ROCm 10): 🚫 Run #39327514105