Repository navigation
[Perf] attention: Capture translated FA4 verify metadata for DSPARK - #44973
Merged
Merged
Conversation
ch-wan
requested review from
BBuf,
DarkSharpness,
Fridge003,
HaiShaw,
HydraQYH,
Qiaolin-Yu,
Ying1123,
celve,
hebiao064,
hnyls2002,
ispobock,
merrymercy and
yuan-luo
as code owners
October 18, 2026 07:22
This was referenced Oct 18, 2026
ch-wan
force-pushed
the
cheng/dev/speculative-write-location-fusion
branch
from
October 18, 2026 08:13
e9d09e3 to
5d4099c
Compare
ch-wan
requested review from
alphabetc1,
hanming-lu,
huangtingwei9988,
xiezhq-hermann and
yizhang2077
as code owners
October 18, 2026 08:13
ch-wan
force-pushed
the
cheng/dev/fa4-unified-verify-metadata
branch
from
October 18, 2026 08:14
fe3202b to
4cf27a5
Compare
ch-wan
force-pushed
the
cheng/dev/speculative-write-location-fusion
branch
from
October 18, 2026 09:02
5d4099c to
f64aab0
Compare
ch-wan
force-pushed
the
cheng/dev/fa4-unified-verify-metadata
branch
from
October 18, 2026 09:02
4cf27a5 to
b550cac
Compare
ch-wan
force-pushed
the
cheng/dev/speculative-write-location-fusion
branch
from
October 18, 2026 12:41
f64aab0 to
d2e166d
Compare
Base automatically changed from
cheng/dev/speculative-write-location-fusion
to
main
October 18, 2026 12:41
ch-wan
force-pushed
the
cheng/dev/fa4-unified-verify-metadata
branch
from
October 18, 2026 12:41
b550cac to
32ca1ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack (oldest at bottom):
Current head
32ca1aeab5, based on main2e9b2cacda. Stack predecessor: #44972. The Files changed tab isolates this PR from its predecessor.Motivation
DSPARK with FA4 and unified memory needs physical FULL/SWA page tables refreshed from live allocator mappings on graph replay. Building translated verify metadata outside capture adds scheduler work and launches.
Modifications
Replayed onto the corrected prerequisites; the launch-size comment reflects the translated gather path.
CI registration updates
Updated
est_timein 4 affected test files from observed file-level CI timings, including process/import cost and margin. Existing estimates with sufficient margin are retained. The expanded weekly configurator test also passed all 11 cases in a 30.1-second CPU measurement.The CI registry check validated 2,960 registrations before landing. An AST comparison confirmed that this follow-up changes registration metadata only. Runtime test measurements elsewhere in this description refer to their stated earlier revisions.
Accuracy Tests
Earlier combined stack
b550cacde6adds a test-fixture correction in #43326: the Gemma4 read-stream fixture declares its FULL address space, and the HiSparse registry test uses realCacheInitParamsfor the retained-window calculation. Both complete test files pass locally with GPUs hidden: 4 Gemma4 tests and 26 registry tests. Pre-commit passed. The five descendant patches are unchanged (git range-diff); this follow-up changes no production code. The earlier 455-test run did not cover these two files; GitHub CI has not yet been revalidated for this head.Validation before the test-fixture follow-up, on combined stack
4cf27a551c: 455 tests and 921 subtests passed on B300, plus the two widened-history regressions against Rust TreeCore. The new FULL-fallback metadata cases cover eager execution and CUDA graph replay. New allocation-reclaim, explicit-prefill and JIT-reuse regressions fail on the previous code and pass with the fixes. These are combined-stack checks, not independent model reruns of each PR.81 tests and 40 subtests passed on B300 at the previous head
fe3202b894, covering decode metadata, graph replay, fused placement, unified speculative admission, and page-major backend policy.Speed Tests and Profiling
The following throughput and exact-output measurements are from the previous stack revision, before the review fixes.
Prior combined-stack validation at
fe3202b894ef1cb045e2ff6b816558927bbdc055, based on main3671503e44:Inkling-Small-NVFP4 (revision
b6a99534467840620d411e4cd4ad5819b2610d9c) with Inkling-Small-DSpark (revision736501c3901cfc6bbb53ba382781eb0e5d9ad66a), 4x B300 / TP4, FA4 target and draft, CUDA graphs, page size 128, greedy decoding, 48 requests with fixed synthetic 512-token inputs and 2048 output tokens. Default and unified runs used identical inputs and model revisions. The test flushed the prefix cache between cases, performed a 128-token warmup, then an exact-output run with logprobs and two throughput runs without logprobs.This validates the combined stack on one controlled workload; it is not an isolated before/after benchmark of any individual optimization or a task-accuracy evaluation. PyTorch 2.14.1+cu130, Triton 3.8, FlashInfer 0.7.1. Main arguments:
--tp 4 --attention-backend fa4 --speculative-algorithm DSPARK --speculative-draft-attention-backend fa4 --page-size 128 --mem-fraction-static 0.8 --max-running-requests 48 --mamba-radix-cache-strategy extra_buffer --swa-full-tokens-ratio 0.1 --mamba-full-memory-ratio 0.1 --random-seed 1234;SGLANG_RAGGED_VERIFY_MODE=static. Only the unified arm adds--enable-unified-memory.Checklist
CI States
Latest PR Test (Base): 🚫 Run #39128369844
Latest PR Test (Extra): 🚫 Run #39128369818
Latest PR Test (AMD ROCm 10): 🚫 Run #39128369836