Repository navigation
Conversation
mmangkad
marked this pull request as ready for review
October 17, 2026 11:19
…se-b-light # Conflicts: # test/registered/kernels/ops/gemm/test_fp8_kernel.py
Contributor
Author
|
/rerun-test -c |
Contributor
|
🚀 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of the series that splits #41231 into reviewable PRs, one CI lane each (first: #44876). This one moves 27 light base-b test files (kernels/ops, moe, unit, layers, mem_cache, model_loading, prefill_only) from 1-gpu-large (H100) to 1-gpu-small (RTX 5090). Every change is the
runner_configof oneregister_cuda_ciline, withest_timeset to the measured 5090 duration where the estimate was more than 1.5x low.test_nvfp4_marlinwas already registered on 1-gpu-small (est_time 12, 11s measured); its 1-gpu-large duplicate is dropped.Rule for a file to move: it passes on the 5090 (SM120, 32 GB) with the CI install and env, every test it skips on the 5090 also skips on H100, and where it launches a server, any architecture-dependent default it picks up (e.g. FA3 on H100 vs FlashInfer on SM120) is not what the test is about. No coverage is lost.
Partitions are sized from est_time by
compute_partitions.py, so no workflow change is needed. Independent of #44876 (no shared files).Validation
All 30 candidate files passed on the 1-gpu-5090 runners at
8d58a33e16with/rerun-test -c(run 39021620314), then compared with the same files on H100 in main's scheduled run:test_mhc_kernelsstays on 1-gpu-large: 33 passed, 16 skipped on the 5090 vs 49 passed on H100. The skipped cases are itstest_hopper_*functions, which exercise the SM90-only mHC dispatch.test_topk_padded_region(3),test_fp8_utils(1).test_flash_mla_backendsskips all 15 cases on H100 and runs 14 on the 5090.test_post_capture_kv_sizingis the only file that starts a server; it gets FlashInfer on the 5090 instead of FA3. Post-capture KV sizing has no attention-backend-specific path, and the run confirms the sizing path ran.Merged main
5e630fa571into the branch: main deletedkernels/ops/gemm/test_fp8_kernel.py(#44690), so it is no longer part of this PR. Main changed 9 of the other files since the run above, so all 28 are being rerun on the 5090 with/rerun-test -c.Follow-ups
extra-a, the round-4 class splits, the jit-kernel unit / benchmark lanes and diffusion follow as separate PRs; #41231 tracks them.
CI States
Latest PR Test (Base): ❌ Run #39360950121
Latest PR Test (Extra): ❌ Run #39360950155
Latest PR Test (AMD ROCm 10): ❌ Run #39360950180