Repository navigation
Conversation
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack (oldest at bottom):
CI is run only on the top PR, #44826, which contains both changes.
Motivation
Joint FULL/SWA allocations can evict more cached prefixes than needed. FULL/SWA/Mamba allocations can fail despite recoverable capacity, or discard the entire cache before rejecting an impossible demand.
This continues #39294, preserving Seokwoo Song's original commits, rebased onto
b62a48ee15b94ba428660ca7e021d44946b0802d.Modifications
Accuracy Tests
Fresh validation of this rebased change:
RustUnifiedTreeCore.git diff --checkpassed.Controlled real-allocator comparisons against unchanged main production code, with the same test fixtures, reproduced these results in both eager and lazy modes:
The selected regression cases fail on main and pass on the candidate. Review checked quota semantics, deferred frees, page rounding, locked prefixes, changing move gates, pending reuse, and the compatibility of the rebase.
The FLOAT geometry predicates are sufficient certificates, not a complete feasibility solver. No fresh model-serving, full HiCache, or multi-GPU result is claimed. Historical serving evidence remains in #39294 and is not represented as validation of this head.
Speed Tests and Profiling
The controlled allocator comparisons above validate cache preservation and successful recovery, not serving throughput. No new serving-speed claim.
Checklist
CI States
Latest PR Test (Base): ❌ Run #38988089292
Latest PR Test (Extra): ❌ Run #38988089227
Latest PR Test (AMD ROCm 10): ❌ Run #38988089311