Repository navigation
[Feat] [AMD] docker: Install the sgl-amd-mono monokernel plugin in the ROCm image - #44621
Merged
Merged
Conversation
…ages --monokernel-backend amd needs the sgl-amd-mono plugin, which the ROCm image does not ship. - Clone sgl-amd-mono at a pinned commit (SGL_AMD_MONO_REPO / SGL_AMD_MONO_COMMIT) after the SGLang install and pip install it (no deps), then check its sglang.srt.plugins entry point. - gfx950 images only; ENABLE_SGL_AMD_MONO=0 skips it.
kkHuang-amd
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock and
sogalin
as code owners
October 16, 2026 01:17
HaiShaw
approved these changes
Oct 16, 2026
4 of 5 tasks
kevin-mii
pushed a commit
to kevin-mii/sglang
that referenced
this pull request
Oct 16, 2026
The image pinned 815b104 (sgl-project#44621) while the srt_hip extra pins e07665c, so the image would serve the plugin without the unread decode schedule. Each pin now names the other, since they must move together. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kevin-mii
pushed a commit
to kevin-mii/sglang
that referenced
this pull request
Oct 16, 2026
The ROCm image installs SGLang with the srt_hip (or srt_hip_rocm724) extra, which already installs the plugin at its pyproject pin. sgl-project#44621's clone and editable reinstall then put a second pin on top, so the image and pip could serve different plugin commits. Drop it: the extras' pin is the only one. The plugin declares no dependencies, so the extras install matches the old --no-deps install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kevin-mii
pushed a commit
to kevin-mii/sglang
that referenced
this pull request
Oct 16, 2026
Restores sgl-project#44621's install step (editable checkout, registration check, gfx950 gating, opt-out) that the previous commit removed, and takes its commit from the srt_hip extras of the SGLang being built unless SGL_AMD_MONO_COMMIT overrides it, the way CI reads AITER's pin from this Dockerfile. The image and pip then install the same plugin commit, and a bump is one change in pyproject_other.toml. The build fails if the extras pin different or non-SHA commits, and skips SGLang versions that pin none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
--monokernel-backend amd(the monokernel framework from #44353) needs the sgl-amd-mono plugin, which the ROCm image does not ship, so the option cannot be used with the published images.Modifications
docker/rocm.Dockerfile: after the SGLang install, clone sgl-amd-mono at a pinned commit (SGL_AMD_MONO_REPO,SGL_AMD_MONO_COMMIT),pip install --no-deps -e ., and fail the build if itssglang.srt.pluginsentry point is not registered.--build-arg ENABLE_SGL_AMD_MONO=0skips it. The plugin registers its specs lazily, so nothing changes unless a server passes--monokernel-backend amd.Accuracy Tests
N/A (packaging only).
Speed Tests and Profiling
N/A (packaging only). The install step was run as written with the image's pip (26.2.1, setuptools 79): the package installs and the entry point check passes on gfx950 and gfx950-rocm724, and the step is skipped on gfx942 and gfx1250-rocm1010.
Checklist
Review and Merge Process
/tag-and-rerun-ci,/tag-run-ci-label,/rerun-failed-ciCI States
Latest PR Test (Base): ✅ Run #38834352096
Latest PR Test (Extra): ❌ Run #38834352095
Latest PR Test (AMD ROCm 10): ❌ Run #38834352187