Skip to content

[Fix] glm5.2: Align HiSparse warmup backends and move test to nightly - #44303

Merged
ispobock merged 2 commits into
sgl-project:mainfrom
alphabetc1:fix/glm52-hisparse-warmup-nightly
Oct 14, 2026
Merged

ispobock merged 2 commits into
sgl-project:mainfrom
alphabetc1:fix/glm52-hisparse-warmup-nightly

Conversation

@alphabetc1

@alphabetc1 alphabetc1 commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

The GLM-5.2 PD + HiSparse + MTP test fails during prefill-worker startup after #44256. FlashInfer autotune runs a dummy DECODE forward on the prefill target worker, but only its prefill backend is set to flashmla_kv. Its default trtllm decode backend rejects the packed KV cache: Expected head dim 576 for query and kv_cache, got 576 and 656.

Failure: https://github.com/sgl-project/sglang/actions/runs/38575536780/job/115891733288

Modifications

  • Set the prefill worker's DSA decode backend to flashmla_kv as well, so startup autotune consumes the same KV layout as prefill and PD transfer.
  • Move the full test from extra-b to nightly, using the existing 8-GPU B200 suite and retaining TP4 prefill + TP4/DP4 decode, 500-question GSM8K evaluation, speculative acceptance threshold, and both long-context cases.
  • Reuse the existing B200 nightly workflow and suite; no workflow changes are needed. Preserve scheduled coverage while reducing per-PR contention for B300 capacity.

Accuracy Tests

  • All applicable pre-commit checks passed, including Python formatting, YAML validation, workflow job-name validation, and registered-test CI validation.
  • git diff --check passed.
  • Full 8-GPU B200 validation will be triggered with /rerun-test on this PR; GPU results are pending.

Speed Tests and Profiling

Not run; this changes test configuration and scheduling.

Checklist

  • Format code with pre-commit.
  • Preserve existing E2E assertions and coverage in the scheduled suite.
  • Follow SGLang code style.
  • Complete the full B200 E2E rerun.

CI States

Latest PR Test (Base): ❌ Run #38584612690
Latest PR Test (Extra): ❌ Run #38584612406
Latest PR Test (AMD ROCm 10): ❌ Run #38584612502

@alphabetc1

Copy link
Copy Markdown
Collaborator Author

/rerun-test registered/e2e/models/test_dsa_glm52_hisparse.py

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🚀 8-gpu-b300 (1 test): ✅ View workflow run

cd test/ && python3 registered/e2e/models/test_dsa_glm52_hisparse.py

@alphabetc1

Copy link
Copy Markdown
Collaborator Author

/rerun-test registered/e2e/models/test_dsa_glm52_hisparse.py

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

🚀 8-gpu-b200 (1 test): ✅ View workflow run

cd test/ && python3 registered/e2e/models/test_dsa_glm52_hisparse.py

@ispobock
ispobock merged commit b677851 into sgl-project:main Oct 14, 2026
110 of 122 checks passed
nvpohanh added a commit to YAMY1234/sglang that referenced this pull request Oct 15, 2026
@alphabetc1
alphabetc1 deleted the fix/glm52-hisparse-warmup-nightly branch October 15, 2026 03:53
nvpohanh added a commit to Kh4L/sglang that referenced this pull request Oct 15, 2026
Picks up the sgl-project#21065 MIN_BASE_SHA b677851 (sgl-project#44303) and recent PD-disaggregation changes on main; the relevant CI failure https://github.com/sgl-project/sglang/actions/runs/38547120923/job/115994921014 is unrelated to this PR.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants