Repository navigation
[DSV4.1] Derive the late-layer DP geometry from the captured shape under the breakable prefill graph - #44144
Merged
Conversation
kpham-sgl
requested review from
Fridge003,
ch-wan,
fzyzcjy and
ispobock
as code owners
October 13, 2026 23:13
Collaborator
Author
|
/rerun-test test/registered/e2e/models/test_deepseek_v41_flash_gb300.py |
Contributor
|
🚀 |
Collaborator
Author
|
Validation, done on 2xGB300 (
At TP2 the model needs the Engram host table and |
kpham-sgl
force-pushed
the
kpham/dsv41-replay-dp-bcg
branch
from
October 14, 2026 02:19
c64b38f to
34d8a57
Compare
Collaborator
Author
|
/rerun-test test/registered/e2e/models/test_deepseek_v41_flash_gb300.py |
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #43812 and #43736. Together they admit decoder SWA bounded replay with DP attention under the breakable prefill CUDA graph, but the DP-geometry swap from #43812 skipped itself while the stream was capturing and graph replays never re-run the late-layer loop, so inside the graph the late-layer MoE gather kept the full-shape counts while the hidden states were the tail block (only consistent when the shape fits within
max_running_requests x 128).late_layer_dp_countstakesin_graph: prefill graphs pad every DP rank to one shape, so the tail block is rank-uniform and the counts come from the captured shape with no collective. The capture bakes the geometry in; replays inherit it.enter_late_layer_dpuses device ops only (full_likefor the count tensor,clampon the runner's static non-padded scalar) so it is capture-safe and rebounds per replay.tail_in_graphbefore computing the counts.Accuracy
DeepSeek-V4.1-Flash on 2xGB300, TP2/DP2/EP2, MegaMoE, DSpark, breakable prefill graph, bounded replay on, evaluated with the GB300 CI test's evaluators (
max_running_requests32 per rank, so the in-graph tail block of 4096 rows is smaller than the captured 4096-8192 shapes).DSpark accept length 3.4-4.3. A 10-shot completion GSM8K smoke check on the same box gave 0.925 with the graph vs 0.910 eager, both with replay and DP2.
CI States
Latest PR Test (Base): ❌ Run #38500425131
Latest PR Test (Extra): ❌ Run #38500425143
Latest PR Test (AMD ROCm 10): ❌ Run #38500425067