Repository navigation
[Fix] hisparse: Release HiSparse rows on the KV checksum mismatch and chunked abort exits - #43911
Merged
Merged
Conversation
hnyls2002
requested review from
ShangmingCai,
Ying1123,
merrymercy and
xiezhq-hermann
as code owners
October 12, 2026 19:51
hnyls2002
force-pushed
the
lsyin/sched-pr16
branch
from
October 13, 2026 01:22
77ac62c to
4e54bd5
Compare
hnyls2002
requested review from
ByronHsu,
ClawSeven,
Duyi-Wang,
HaiShaw,
JustinTong0323,
rwang5203,
sogalin,
wisclmy0611,
yeahdongcn and
zijiexia
as code owners
October 13, 2026 01:22
hnyls2002
force-pushed
the
lsyin/sched-pr17
branch
from
October 13, 2026 01:23
28c0754 to
12a9af4
Compare
hnyls2002
marked this pull request as draft
October 13, 2026 02:02
3 of 5 tasks
hnyls2002
force-pushed
the
lsyin/sched-pr16
branch
from
November 3, 2026 08:55
4e54bd5 to
6b086c1
Compare
hnyls2002
force-pushed
the
lsyin/sched-pr17
branch
from
November 4, 2026 00:12
12a9af4 to
3bda040
Compare
hnyls2002
marked this pull request as ready for review
November 4, 2026 00:20
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Collaborator
Author
|
/rerun-test test_kv_checksum.py test_hisparse_unit.py test_disaggregation_hisparse.py test_dsa_glm52_hisparse.py |
Contributor
|
🚀 🚀 🚀 🚀 |
Yuxingwang-intel
pushed a commit
to Yuxingwang-intel/sglang
that referenced
this pull request
Nov 6, 2026
… chunked abort exits (sgl-project#43911)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two exits free a request's KV with
release_kv_cachewithout releasing its HiSparse state first, so the rows leak. Both now callhisparse_coordinator.request_finishedbefore the KV free, under the sameenable_hisparseguard as the other exits._handle_kv_checksum_mismatch): the transfer has already admitted the request into HiSparse, so its host pages and device buffer were never returned.process_pending_chunked_abort): a request aborted between chunks holds only the spec scratch row its extend allocated;request_finishedfrees exactly that (its no-device-buffer branch), and the prefill KV is still freed byrelease_kv_cache.No change without
--enable-hisparse. No stream wait is added or moved;request_finishedkeeps its own wait on the forward stream, as at the other exits.Test plan
/rerun-teston this head:test_hisparse_unit.py(1-gpu-5090): passed, runtest_disaggregation_hisparse.py(8-gpu-h200, PD + HiSparse, DeepSeek-V4-Flash): passed, runtest_dsa_glm52_hisparse.py(8-gpu-b200, HiSparse + speculative decoding): passed, runtest_kv_checksum.py(1-gpu-h100): queued, runCI States
Latest PR Test (Base): 🚫 Run #41746867200
Latest PR Test (Extra): ❌ Run #41746867142
Latest PR Test (AMD ROCm 10): 🚫 Run #41746867236
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: