Repository navigation
[Fix] scheduler: Record weight version events on every request list - #43909
Conversation
688f2b7 to
9f103f0
Compare
608c1d5 to
5a261c6
Compare
9f103f0 to
5e2e57d
Compare
5a261c6 to
4613280
Compare
5e2e57d to
01b52e8
Compare
1caae25 to
c1a20ee
Compare
42daa46 to
411dba1
Compare
8a5008d to
bbfae1f
Compare
|
/rerun-test test_metrics.py test_priority_metrics.py registered/disaggregation/test_disaggregation_basic.py test_utils_update_weights.py test_load_snapshot_server.py test_prefill_complete_allocation.py test_disaggregation_optimistic_prefill.py test_update_weights_from_tensor.py test_update_weights_from_distributed.py test_weight_version_spans.py |
|
🚀 🚀 🚀 |
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
e5a0789 to
02ff2fc
Compare
Readers that collect live requests by hand take them from
Scheduler.request_lists().record_weight_version_changerecorded events only on requests in batch snapshots, the waiting queue, the chunked slot, deferred responses and HiSparse staging, so a request waiting for its grammar, in a PD queue, in the dLLM queue or in a parked uOCR window got no weight-version event. It now records on every request in every list.request_lists()by kind: the waiting, grammar and PD prefill gauges, copied in the prefill, decode and idle reports, become one_update_queue_stats;get_loadsreads the PD queues by kind and drops three queue getters.Behavior change: the fix above.
Test plan
test_records_on_every_request_list: requests in the running, waiting, chunked, grammar and PD sending lists each get the event (the grammar and PD sending ones fail before the fix).test/registered/unit/{managers,disaggregation,lora,utils,dllm,observability}pass locally withSGLANG_IS_IN_CI=1, apart from failures the base has too.CI States
Latest PR Test (Base): 🚫 Run #41605782929
Latest PR Test (Extra): ❌ Run #41605782910
Latest PR Test (AMD ROCm 10): ❌ Run #41605782777
Tip
Base CI only covers the core cases, and its workload may not exercise your change. Use
/rerun-testto run the tests your change touches, or copy this prompt for an agent: