Skip to content

[AMD] Fix test_compact_attention_hip.py CI - #43836

Merged
HaiShaw merged 1 commit into
sgl-project:mainfrom
1am9trash:dsv41-qkpv-fp8
Oct 12, 2026
Merged

HaiShaw merged 1 commit into
sgl-project:mainfrom
1am9trash:dsv41-qkpv-fp8

Conversation

@1am9trash

@1am9trash 1am9trash commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Motivation

Fix issue #43765.

  • PR#41020 added compact_attention_hip, the DeepSeek-V4.1 sparse decode attention kernel for gfx950. Its inner attention step (QK matmul, softmax, PV matmul) is a helper called _qkpv_fp8, which it imported from aiter's private _gluon_kernels module.
  • That helper is internal to aiter, not a public API, so aiter can change or remove it at any time. It was removed in aiter PR#4919 (09/18). After PR#42023 moved sglang to an aiter version that includes that change, the import fails with ModuleNotFoundError. This breaks test_compact_attention_hip in AMD CI.

Modifications

Copy _qkpv_fp8 into compact_attention_hip.py unchanged

Accuracy Tests

Speed Tests and Profiling

Before:

File "/sgl-workspace/sglang/python/sglang/kernels/ops/attention/dsv4/compact_attention_hip.py", line 7, in <module>
    from aiter.ops.triton._gluon_kernels.gfx950.attention.pa_decode_sparse import _qkpv_fp8
ModuleNotFoundError: No module named 'aiter.ops.triton._gluon_kernels.gfx950.attention.pa_decode_sparse'

After:

test_matches_torch_over_both_caches_splits_and_empty_rows ... ok
Ran 1 test in 6.436s
OK

None.

Checklist

Review and Merge Process

  1. Ping Merge Oncalls to start the process. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • Common commands include /tag-and-rerun-ci, /tag-run-ci-label, /rerun-failed-ci
  4. After green CI and required approvals, ask Merge Oncalls or people with Write permission to merge the PR.

CI States

Latest PR Test (Base): ❌ Run #38238994941
Latest PR Test (Extra): ❌ Run #38238994573
Latest PR Test (AMD ROCm 10): ❌ Run #38238994942

@michaelzhang-ai

Copy link
Copy Markdown
Collaborator

Re-triggered CI now that run-ci is set (the earlier runs failed at the PR gate before the label was added):

Will update here with the result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

amd jit-kernel run-ci CI: run the baseline test suite on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants