Repository navigation
fix accuracy issue - #4376
Merged
Merged
fix accuracy issue#4376
Conversation
zhyncs
requested review from
BBuf,
HandH1998,
ispobock,
merrymercy and
yizhang2077
as code owners
March 13, 2025 09:05
Contributor
Author
| nvcc_flags.append("-gencode=arch=compute_100,code=sm_100") | ||
| nvcc_flags.append("-gencode=arch=compute_100a,code=sm_100a") | ||
| else: | ||
| nvcc_flags.append("-use_fast_math") |
Contributor
There was a problem hiding this comment.
感觉这个影响更大,因为 fast_math 实现是 用 多项式拟合,超越函数,倒数,基本都是按taylor展开写,应该会掉很多精度。
Collaborator
There was a problem hiding this comment.
We need to be very cautious about it: https://simonbyrne.github.io/notes/fastmath/
At the same time we will verify the accuracy of per token quant asap in our recommendation use cases
hebiao064
pushed a commit
to hebiao064/sglang
that referenced
this pull request
Mar 13, 2025
0826joyce
pushed a commit
to 0826joyce/sglang-perf-opt
that referenced
this pull request
May 19, 2026
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Checklist