Repository navigation
[DeepSeek-V4.1] Admit the NIXL transfer backend for DSpark PD #43734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
test/registered/unit/server_args/test_dsv41_dspark_pd_transport.py
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove unit test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| """DeepSeek-V4.1 DSpark PD admits the NIXL transfer backend alongside Mooncake.""" | ||
|
|
||
| import unittest | ||
| from types import SimpleNamespace | ||
| from unittest import mock | ||
|
|
||
| from sglang.srt.arg_groups.deepseek_v4_hook import validate_deepseek_v41_features | ||
| from sglang.srt.model_executor.cuda_graph_config import ( | ||
| Backend, | ||
| CudaGraphConfig, | ||
| PhaseConfig, | ||
| ) | ||
| from sglang.srt.server_args import ServerArgs | ||
| from sglang.srt.speculative.ragged_verify import RaggedVerifyMode | ||
| from sglang.test.ci.ci_register import register_cpu_ci | ||
| from sglang.test.test_utils import CustomTestCase | ||
|
|
||
| register_cpu_ci(est_time=2, suite="base-a-test-cpu") | ||
|
|
||
| _RAGGED_VERIFY_MODE = "sglang.srt.speculative.ragged_verify.read_ragged_verify_mode" | ||
|
|
||
|
|
||
| def _pd_args(**overrides): | ||
| args = ServerArgs( | ||
| **{ | ||
| "model_path": "local-deepseek-v41", | ||
| "attention_backend": "dsv4", | ||
| "speculative_algorithm": "DSPARK", | ||
| "disaggregation_mode": "prefill", | ||
| "disaggregation_transfer_backend": "mooncake", | ||
| "cuda_graph_config": CudaGraphConfig( | ||
| prefill=PhaseConfig(backend=Backend.DISABLED) | ||
| ), | ||
| **overrides, | ||
| } | ||
| ) | ||
| args._model_config = SimpleNamespace( | ||
| hf_config=SimpleNamespace( | ||
| architectures=["DeepseekV4ForCausalLM"], model_type="deepseek_v41" | ||
| ), | ||
| hf_text_config=SimpleNamespace(model_type="deepseek_v41"), | ||
| is_multimodal=False, | ||
| ) | ||
| return args | ||
|
|
||
|
|
||
| class TestDSV41DSparkPDTransport(CustomTestCase): | ||
| def test_nixl_and_mooncake_are_admitted(self): | ||
| for backend in ("mooncake", "nixl"): | ||
| with ( | ||
| self.subTest(backend=backend), | ||
| mock.patch(_RAGGED_VERIFY_MODE, return_value=RaggedVerifyMode.STATIC), | ||
| ): | ||
| validate_deepseek_v41_features( | ||
| _pd_args(disaggregation_transfer_backend=backend) | ||
| ) | ||
|
|
||
| def test_other_transports_are_rejected(self): | ||
| with mock.patch(_RAGGED_VERIFY_MODE, return_value=RaggedVerifyMode.STATIC): | ||
| with self.assertRaisesRegex(ValueError, "Mooncake or NIXL"): | ||
| validate_deepseek_v41_features( | ||
| _pd_args(disaggregation_transfer_backend="fake") | ||
| ) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| unittest.main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove ai gen comments