Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions python/sglang/srt/arg_groups/deepseek_v4_hook.py
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,9 @@ def validate_deepseek_v41_features(server_args: ServerArgs) -> None:
read_ragged_verify_mode,
)

# The DSpark aux (first token, draft state, hidden states) travels on the
# prefill-side aux WRITE path that disaggregation/common implements for
# every transfer backend, so NIXL carries it the same way Mooncake does.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove ai gen comments

# CP size may still be implicit here; validate_deepseek_v4_cp resolves it.
supported_prefill_cp = (
cfg.disaggregation_mode == "prefill"
Expand All @@ -297,15 +300,15 @@ def validate_deepseek_v41_features(server_args: ServerArgs) -> None:
)
if (
read_ragged_verify_mode() is not RaggedVerifyMode.STATIC
or cfg.disaggregation_transfer_backend != "mooncake"
or cfg.disaggregation_transfer_backend not in ("mooncake", "nixl")
or (
(cfg.enable_prefill_cp or cfg.attn_cp_size != 1)
and not supported_prefill_cp
)
or cfg.dcp_size != 1
):
raise ValueError(
"DeepSeek-V4.1 DSpark PD requires static verify, Mooncake, "
"DeepSeek-V4.1 DSpark PD requires static verify, Mooncake or NIXL, "
"DCP=1, and CP=1 on decode. Prefill CP requires "
"--enable-prefill-cp with the interleave strategy. "
"DP attention is supported when "
Expand Down
67 changes: 67 additions & 0 deletions test/registered/unit/server_args/test_dsv41_dspark_pd_transport.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unit test

Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
"""DeepSeek-V4.1 DSpark PD admits the NIXL transfer backend alongside Mooncake."""

import unittest
from types import SimpleNamespace
from unittest import mock

from sglang.srt.arg_groups.deepseek_v4_hook import validate_deepseek_v41_features
from sglang.srt.model_executor.cuda_graph_config import (
Backend,
CudaGraphConfig,
PhaseConfig,
)
from sglang.srt.server_args import ServerArgs
from sglang.srt.speculative.ragged_verify import RaggedVerifyMode
from sglang.test.ci.ci_register import register_cpu_ci
from sglang.test.test_utils import CustomTestCase

register_cpu_ci(est_time=2, suite="base-a-test-cpu")

_RAGGED_VERIFY_MODE = "sglang.srt.speculative.ragged_verify.read_ragged_verify_mode"


def _pd_args(**overrides):
args = ServerArgs(
**{
"model_path": "local-deepseek-v41",
"attention_backend": "dsv4",
"speculative_algorithm": "DSPARK",
"disaggregation_mode": "prefill",
"disaggregation_transfer_backend": "mooncake",
"cuda_graph_config": CudaGraphConfig(
prefill=PhaseConfig(backend=Backend.DISABLED)
),
**overrides,
}
)
args._model_config = SimpleNamespace(
hf_config=SimpleNamespace(
architectures=["DeepseekV4ForCausalLM"], model_type="deepseek_v41"
),
hf_text_config=SimpleNamespace(model_type="deepseek_v41"),
is_multimodal=False,
)
return args


class TestDSV41DSparkPDTransport(CustomTestCase):
def test_nixl_and_mooncake_are_admitted(self):
for backend in ("mooncake", "nixl"):
with (
self.subTest(backend=backend),
mock.patch(_RAGGED_VERIFY_MODE, return_value=RaggedVerifyMode.STATIC),
):
validate_deepseek_v41_features(
_pd_args(disaggregation_transfer_backend=backend)
)

def test_other_transports_are_rejected(self):
with mock.patch(_RAGGED_VERIFY_MODE, return_value=RaggedVerifyMode.STATIC):
with self.assertRaisesRegex(ValueError, "Mooncake or NIXL"):
validate_deepseek_v41_features(
_pd_args(disaggregation_transfer_backend="fake")
)


if __name__ == "__main__":
unittest.main()
Loading