Repository navigation
[AMD] Run the MiniMax indexer CP test on MI35X, not MI300 - #43259
Merged
hnyls2002 merged 2 commits intoOct 9, 2026
Merged
Conversation
Indexer CP is gated to gfx950, and the native top-k selector the test compares against needs 128 KB of LDS for its score kernel; MI300 (gfx942) has 64 KB, so the test raised OutOfResources on every stage-b MI300 run since it landed in sgl-project#41488. It passes on gfx950. Reported by @bingxche on sgl-project#41488. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The suite name already says where it runs; the reason is in the PR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
test/registered/amd/test_minimax_indexer_cp.py(added in #41488) has failed on everystage-b-test-1-gpu-small-amdMI300 run since it landed, as @bingxche reported on #41488 (first failure, still failing 2026-10-08):The error comes from the reference side of the test:
flash_decode_with_topk_idx's score kernel needs 128 KB of LDS, and MI300 (gfx942) has 64 KB. Indexer CP itself is gfx950-only (unsupported_reasonreturns"requires AMD gfx950"), so the test belongs on MI35X anyway.Modifications
Register the test in
stage-b-test-1-gpu-small-amd-mi35xinstead ofstage-b-test-1-gpu-small-amd. No code change.Accuracy Tests
On MI350X (gfx950):
Suite collection: the file is now in
stage-b-test-1-gpu-small-amd-mi35xand no longer instage-b-test-1-gpu-small-amd;validate_all_suitespasses.Checklist
🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #37873098166
Latest PR Test (Extra): ❌ Run #37873097914
Latest PR Test (AMD ROCm 10): ❌ Run #37873098153