Repository navigation
Conversation
added 8 commits
October 8, 2026 09:45
mmangkad
requested review from
AgainstEntropy,
BBuf,
Fridge003,
HaiShaw,
JustinTong0323,
Qiaolin-Yu,
Ying1123,
b8zhong,
hnyls2002,
jybsuper,
kevin-mii,
lifuhuang,
merrymercy,
mickqian,
niehen6174,
ping1jing2,
yichiche and
yushengsu-thu
as code owners
October 8, 2026 09:58
…te-limit # Conflicts: # python/sglang/srt/model_loader/weight_utils.py # python/sglang/srt/utils/common.py # python/sglang/test/test_utils.py
This was referenced Oct 10, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Loading a cached model still calls the HF Hub API: transformers' revision lookups (new in 5.18) and repo listings, sglang's own checks, and dataset loads. In CI this exhausts the shared
apirate limit (429). Several loads also ignored--revisionand readmain.Merged main after #43229 landed; conflicts resolved as follows:
Engineoffline hookEnginestartups, which this PR did notrefs/<revision>lookupcache_dir; this PR reusesfind_local_repo_dir--revision--revision, so revision-pinned models (e.g. Inklingtest) never went offlineEnginehook required tokenizer files for drafts, which they usually lack, so in-process speculative startups never went offlineChanges
get_tokenizer/get_processortake onerevisionget_cached_repo_tree)Enginepaths honor--revisionand check drafts by config and weights only; cross-repoauto_mapcode is acceptedVerification
HF Hub
apirequests per launch (server + client), CI mode, warm cache. Outputs identical.--revision test, direct--revision test, CI harnessLongBench-v2 and all 30 MMMU subjects match the previous loads.
CI States
Latest PR Test (Base): ✅ Run #37894247607
Latest PR Test (Extra): ❌ Run #37894247194
Latest PR Test (AMD ROCm 10): ❌ Run #37894247523