Repository navigation
[DSv4] Fix shared index cache accessor page size - #42832
Merged
kpham-sgl merged 4 commits intoOct 7, 2026
Merged
Conversation
kpham-sgl
force-pushed
the
codex/fix-dsv4-indexer-page-size
branch
from
October 7, 2026 04:17
36209e5 to
42aeae1
Compare
kpham-sgl
marked this pull request as ready for review
October 7, 2026 04:18
kpham-sgl
requested review from
Ying1123,
alphabetc1,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
October 7, 2026 04:18
Collaborator
Author
|
/rerun-test test/registered/unit/mem_cache/test_dsv4_compressed_pools.py test/registered/disaggregation/test_disaggregation_dsv4.py |
Contributor
|
🚀 🚀 |
Collaborator
Author
|
Manually verified on 4×H200 (TP4) with DSv4 Flash FP8: a 9000-token prefill hits the non-paged path with its default 8192-row threshold. Main crashes with the missing |
Collaborator
Author
|
/rerun-test test/registered/disaggregation/test_disaggregation_dsv4.py |
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSv4's non-paged FP8 indexer prefill crashes because
DeepSeekV4IndexerPooldoes not expose the storage page size expected by the shared DSA accessor. #42178 introduced this dependency; #42671 renamed the field toindex_page_size. Reported in this comment.Set
index_page_sizeto the pool's physical page size.Validation:
git diff --checkpassed.index_page_sizeerror for 64- and 128-slot pages; the PR returns exactly the expected keys and scales for two sequences with non-sequential pages and partial final pages.CI States
Latest PR Test (Base): ❌ Run #37577779907
Latest PR Test (Extra): ❌ Run #37577779610
Latest PR Test (AMD ROCm 10): ❌ Run #37577779910