Repository navigation
[Fix] Correct pooled page IDs in target verify replay - #42722
Closed
leonardHONG wants to merge 1 commit into
Closed
leonardHONG wants to merge 1 commit into
leonardHONG wants to merge 1 commit into
Conversation
This was referenced Oct 6, 2026
Collaborator
|
Fixed by #42750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #42178, pooled page IDs must be divided by
pool_size. The target verify replay path added in #42489 still copied physical page IDs, causing incorrect indices.Apply floor division directly into the existing buffer to match
build_pooled_page_table_64()and preserve CUDA graph buffer addresses.CI States
Latest PR Test (Base): ❌ Run #37420897614
Latest PR Test (Extra): ❌ Run #37420897319
Latest PR Test (AMD ROCm 10): ❌ Run #37420897425