support llava video - #426
Merged
merrymercy merged 15 commits intoMay 13, 2024
Merged
Conversation
merrymercy
requested changes
May 12, 2024
Contributor
Author
|
Looks like there are no conflict at README.md |
merrymercy
reviewed
May 12, 2024
merrymercy
left a comment
merrymercy
left a comment
Contributor
There was a problem hiding this comment.
We are very close now, but I found several obvious errors that make the code unable to run. Could you fix them and do one test?
Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
merrymercy
reviewed
May 13, 2024
Contributor
|
Your PR makes llava-v1.6 not runnable. Could you do more tests and let me know it is fully ready for merge? Error: |
Contributor
|
@ZhangYuanhan-AI Thanks! It is merged |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
Garrybest
pushed a commit
to Garrybest/sglang
that referenced
this pull request
Jan 9, 2026
vschandramourya
pushed a commit
to vschandramourya/sglang
that referenced
this pull request
Feb 3, 2026
…oject#426) * Copy OSS code from 9054e844 on 20251123 * pdate ci --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
HanHan009527
pushed a commit
to HanHan009527/sglang
that referenced
this pull request
Apr 7, 2026
efschu
added a commit
to efschu/htsglang
that referenced
this pull request
Aug 2, 2026
…fill indexer (sgl-project#449) MiB-budgeted query-row loop over the existing KV-page loop (sgl-project#395 discipline, sgl-project#426 composition preserved); B-fold KV-gather duplication bounded from factor B to the budgeted row count; bit-identical (atol=0) against the unchunked path and the untouched single-pass reference. Collective audit clean under uneven-TP rank divergence. GPU measurement (peak VRAM per rank primary) pending — NOTE_449 §5. Full dedup of the B-fold gather stays open as ANALYSE_447 candidate C.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.