Repository navigation
[XPU][CI] Disable test_xpu_graph until tc_piecewise is removed (#41634) - #42524
Merged
Merged
Conversation
arathi-hlab
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
ispobock,
merrymercy and
yizhang2077
as code owners
October 4, 2026 16:40
This was referenced Oct 4, 2026
Collaborator
|
sglang is dropping tc_piecewise graph #41634. I recommend just disable the failed xpu test case in ci right now, and refactor once the above PR landed. no need to fix upon existing tc piecewise any more. |
arathi-hlab
force-pushed
the
fix-xpu-graph-dynamo
branch
from
October 5, 2026 01:57
163c2ab to
b578001
Compare
XPU CI (stage-a-test-1-gpu-xpu) fails on every PR in test/registered/xpu/test_xpu_graph.py: the tc_piecewise prefill graph compiles the Qwen2 decoder with fullgraph=True, and since sgl-project#42301 the forward builds msgspec.Struct layer-boundary values that Dynamo (torch 2.13) cannot construct inside a compiled region. tc_piecewise is being removed in sgl-project#41634, so rather than reworking the layer-boundary classes for a graph mode that is going away, mark the test disabled in its CI registration (run_suite.py then skips the file) and refactor the XPU graph test once sgl-project#41634 lands.
arathi-hlab
force-pushed
the
fix-xpu-graph-dynamo
branch
from
October 5, 2026 02:03
b578001 to
87cb76f
Compare
mingfeima
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
XPU CI (
stage-a-test-1-gpu-xpu) fails on every PR intest/registered/xpu/test_xpu_graph.py, e.g. https://github.com/sgl-project/sglang/actions/runs/37169947775/job/111340729252 (PR #40190):The test runs Qwen2.5-1.5B with the
tc_piecewiseprefill graph, which compiles the decoder withfullgraph=True. Since #42301 the Qwen2 forward builds layer-boundary values that aremsgspec.Structs, and Dynamo (torch 2.13) cannot construct amsgspec.Structinside a compiled region.Modifications
Per @mingfeima's review (#42524 (comment)):
tc_piecewiseis being removed in #41634, so this PR no longer reworks the layer-boundary classes. It only markstest_xpu_graph.pyasdisabled=in itsregister_xpu_ci(...)call, with a reason pointing at #41634, sorun_suite.pyskips the file (same mechanism astest/registered/xpu/test_triton_attention_backend.py). The XPU graph test will be refactored once #41634 lands.The earlier version of this PR (plain
__slots__classes for the per-forward layer-boundary values, rebased from #41845) is dropped.Verification
pre-commit run --files test/registered/xpu/test_xpu_graph.pypasses.ut_parse_one_file) returns the file withdisabled=set, sorun_suite.py --hw xpulists it under skipped tests instead of running it.stage-a-test-1-gpu-xpushould be green on this PR.CI States
Latest PR Test (Base): ⏳ Run #37253885968⚠️ Not enabled -- add
Latest PR Test (Extra):
run-ci-extralabel to opt in.Latest PR Test (AMD ROCm 10): ⏳ Run #37253886036