Repository navigation
[Feat] gdn: Add --enable-linear-lossless-verify for bit-exact tuple replay in spec verify #42388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsthe29
wants to merge
14
commits into
sgl-project:main
Choose a base branch
from
hsthe29:lossless-gdn-tuple-verify
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,080
−24
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3df4663
[GDN] Add --enable-linear-lossless-verify: bit-exact tuple replay for…
hsthe29 f3d9467
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 bbe2b88
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 4f93f5a
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 ff33023
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 c7152e9
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 9f1f957
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 24b47a2
[GDN] Adapt lossless verify to the mem-cache refactor on main
hsthe29 d1097b7
Preserve the flag-off XPU verify signature and reject lossless
BBuf 04c2abf
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 3af8fb4
[GDN] Document --enable-linear-lossless-verify and append its positio…
hsthe29 413bdb6
[GDN] Run the lossless verify parity checks on MI35x for one request …
hsthe29 1e61985
[GDN] Whitelist the lossless verify hook and stub its sizing helper i…
hsthe29 bdb93dc
Merge branch 'main' into lossless-gdn-tuple-verify
hsthe29 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Checking the backend name does not exclude Ascend: this configuration passes validation, but the registry selects the Ascend verify and commit implementations. The pool removes intermediate_ssm while the Ascend commit still consumes it and accesses its shape, so the first commit fails. Reject unsupported platforms before allocating the tuple-only pool.