Skip to content

[AMD] Deselect slow survives_real_pytest_runner from diffusion unit step #42243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelzhang-ai wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −2
Open

[AMD] Deselect slow survives_real_pytest_runner from diffusion unit step #42243

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a7c1592
[AMD] Fix multimodal-gen diffusion unit suite on MI300
michaelzhang-ai Oct 2, 2026
da8cdd1
Merge remote-tracking branch 'origin/main' into fix/amd-mmgen-unit-suite
michaelzhang-ai Oct 4, 2026
6afe7d5
[AMD] Deselect CUDA-only and HIP-relaxed tests in diffusion unit step
michaelzhang-ai Oct 4, 2026
c2c5933
Merge remote-tracking branch 'origin/main' into fix/amd-mmgen-unit-suite
michaelzhang-ai Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/pr-test-amd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,10 @@ jobs:
# Split unit files across the four existing containers to stay within
# the step timeout without repeating image pulls and dependency installs.
# Run after failed server tests too, so a regression cannot hide them.
# Skips the CUDA-only ltx2_vae_channels_last memory-format assertion.
# Skips the CUDA-only ltx2_vae_channels_last memory-format assertion, and
# survives_real_pytest_runner: its 9 cases each re-import sglang 7 times,
# ~20 min on mi300, which pushes its shard to ~25 of the 30 min. Both
# still run in the CUDA diffusion unit lane.
- name: Run diffusion unit tests
if: success() || failure()
timeout-minutes: 30
Expand All @@ -881,7 +884,7 @@ jobs:
--suite unit \
--partition-id ${{ matrix.part }} \
--total-partitions 4 \
-k "not ltx2_vae_channels_last" \
-k "not ltx2_vae_channels_last and not survives_real_pytest_runner" \
${{ needs.check-changes.outputs.continue_on_error == 'true' && '--continue-on-error' || '' }}

- name: Upload diffusion failure artifacts
Expand Down
Loading