Repository navigation
[AMD] Skip the AITER #6042/#5967 patches on gfx1250 - #42219
Merged
yctseng0211 merged 1 commit intoOct 2, 2026
Merged
yctseng0211 merged 1 commit into
yctseng0211 merged 1 commit into
Conversation
…1250 The gfx1250-rocm1000 image pins an older AITER (a6d2b564) than the gfx942/gfx950 images. The ROCm/aiter#6042 cherry-pick conflicts in pa_decode_sparse.py there, and the ROCm/aiter#5967 CSV diff targets files that do not exist yet, so the nightly publish-gfx1250 build fails. Apply both patches only to non-gfx1250 builds.
michaelzhang-ai
requested review from
Fridge003,
HaiShaw,
ishandhanani,
ispobock,
sogalin and
yctseng0211
as code owners
October 2, 2026 10:14
yctseng0211
approved these changes
Oct 2, 2026
This was referenced Oct 2, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Apply the ROCm/aiter#6042 cherry-pick and the ROCm/aiter#5967 FMoE CSV diff only when
GPU_ARCH_LIST != gfx1250.Why
#42023 added both patches to the shared AITER clone step, but
gfx1250-rocm1000still pins AITERa6d2b564, which is 412 commits behind thee7d2453fpin the patches were written for. Since then the nightlypublish-gfx1250job fails (run 36861890479):Fixing only the cherry-pick would not be enough: the #5967 diff modifies
dsv41_fp4_{tuned,untuned}_fmoe.csv, which do not exist ata6d2b564, sogit applyfails next.Notes for the reviewer
The gate uses
GPU_ARCH_LIST, like the other gfx1250-specific paths in this file. gfx942/gfx950 are unchanged. Both patches target DSV4.1 paths that gfx1250 did not have before #42023 either.Test plan
Ran the clone/patch/revert part of this
RUNstep (without submodule update andpip install) against a local AITER clone:gfx950@e7d2453f: cherry-pick and CSV apply succeed, same as before.gfx1250@a6d2b564: patches skipped,sedand the four gfx1250 reverts apply cleanly.gfx1250@a6d2b564with the current block: reproduces the cherry-pick conflict and the missing-CSVgit applyerror.Full
publish-gfx1250build of this branch viaworkflow_dispatchsucceeded: run 36999577158. The AITER step skips both patches and the four gfx1250 reverts apply.