Repository navigation
Conversation
mks-hash
requested review from
Ying1123,
alphabetc1,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
October 1, 2026 22:55
mks-hash
force-pushed
the
fix/hicache-prefetch-failure-cleanup
branch
from
October 4, 2026 18:25
37d07d6 to
c109823
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Current main (
7a719e9a65e7f52b012ab37211b5f174e5d3d38d) now catches storage query/read batch exceptions in unified-memory mode. Two lifecycle gaps remain: a duplicate terminal ACK can reclaim the same tail twice, and an exception after acknowledged batch progress can be published as a partial successful restore instead of an explicit terminal failure.With the unified-memory flag enabled, the ten regression cases reproduce 2 failures / 8 passes on this base: allocator
Double-free detectedon duplicate completion, and partial publication after the second batch raises. The latter is a terminal-outcome/cleanup contract difference, not a claim that all shared published KV is leaked. Earlier worker-death reproducers on the old base are retained as regression coverage, not presented as current unified-mode behavior.Modifications
finallyand query/read fallback for unsupported consumers._retire_ongoing_prefetchcleanup helper; do not reintroduce the old inline reclamation.Scope remains resident FULL, synchronous finite I/O and no rank collectives/PP tickets. No distributed exception recovery, permanently blocked-I/O reclamation, scheduler redesign, retries or proactive-prefetch feature is added. Production diff is 74 additions / 3 deletions in three files; the fourth file contains regression tests.
Accuracy Tests
Refreshed against the base above:
git diff --checkpassed. Rust hooks had no matching files; no Rust validation is claimed.CPU fixtures use real pools/controller/file I/O, unpinned host tensors and fixture-only host admission-budget accommodations on this constrained machine. The page-envelope accommodation was external to this branch, applies only to tiny allocations, and does not alter production runtime.
No new GPU H2D/model-inference run was performed against this refreshed SHA. Previous GPU evidence remains tied to its recorded source versions.
Speed Tests and Profiling
N/A: lifecycle correctness contribution; no performance claim.
Checklist
CI States
Latest PR Test (Base): ❌ Run #37224418283
Latest PR Test (Extra): ❌ Run #37224417998
Latest PR Test (AMD ROCm 10): ❌ Run #37224418252