Repository navigation
[Router] Document peer bootstrap: flags, RBAC, downward API, probe implications - #42049
Merged
Merged
Conversation
The feature cannot function without deployment wiring that until now was described only inside the e2e manifest: the EndpointSlice RBAC, the downward-API env trio for self-exclusion, and a selector that must match Service labels rather than pod labels. Document all of it where the other router features are documented, with the four flags, their defaults, the readiness-probe implication of the bootstrap deadline, and pointers to the worked manifest and the metric table. Follow-up from the #40687-#40699 stack review, item 4. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
github-actions
Bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only follow-up from the peer-bootstrap stack review (#40687–#40699): the feature's four flags and its deployment requirements appeared nowhere user-facing — the RBAC, downward-API and selector wiring lived only inside the e2e manifest.
Adds a
### Peer bootstrap (Kubernetes)section under Running, following the pattern of the neighbouring feature sections:--kv-peer-selector; requires--policy cache_awarewith the local radix tree and--service-discovery, which the CLI enforces);--kv-bootstrap-timeout-ms;--kv-bootstrap-seed-requiredsemantics: bounded hold at max(3× the bootstrap timeout, 60s), delays a failed seed rather than shipping it cache-blind, cannot stall a rollout indefinitely;get/list/watchonendpointslices(already granted by the worker-discovery Role), thePOD_NAME/POD_NAMESPACE/POD_IPdownward-API trio for self-exclusion, surge-only rollouts;tests/e2e/k8s_integration/manifests/kv-bootstrap.yaml) and thesgl_router_kv_bootstrap_*metric table inmonitoring/README.md.All defaults and semantics verified against the code (
DEFAULT_KV_BOOTSTRAP_TIMEOUT_MS,DEFAULT_KV_BOOTSTRAP_FETCH_TIMEOUT_CAP_MS,seed_gate_timeout,manifests/rbac.yaml). No code changes.🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ✅ Run #36851998663
Latest PR Test (Extra): ❌ Run #36851998470
Latest PR Test (AMD ROCm 10): ➖ No AMD PR run found for this commit.