Repository navigation
Conversation
#41404 calls ensure_abort_notified() on every deferrable failed receiver, but only CommonKVReceiver defines it, so FakeKVReceiver crashes the decode scheduler (test_disaggregation_basic.py on base-b-test-2-gpu-large). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
|
/rerun-test registered/disaggregation/test_disaggregation_basic.py |
kpham-sgl
requested review from
ByronHsu,
Duyi-Wang,
HaiShaw,
ShangmingCai,
hnyls2002 and
sogalin
as code owners
September 29, 2026 00:54
Contributor
|
Results for 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#41404 calls
kv_receiver.ensure_abort_notified(force_arm=True)inpop_transferredfor any deferrable failed receiver, but onlyCommonKVReceiverdefines it.FakeKVReceivercrashes the decode scheduler withAttributeError, breakingtest_disaggregation_basic.pyon scheduled base CI (job).Add a no-op default on
BaseKVReceiver: a fake receiver has no in-flight writes, soabort_notifiedstays False and decode releases immediately.🤖 Generated with Claude Code
CI States
Latest PR Test (Base): ❌ Run #36505363571
Latest PR Test (Extra): ❌ Run #36505363280
Latest PR Test (AMD ROCm 10): ❌ Run #36505363516