Repository navigation
[AMD] Fix MiniMax-M3 EAGLE3 verification on ROCm - #41497
Merged
HaiShaw merged 2 commits intoOct 1, 2026
Merged
Conversation
zijiecode
requested review from
Fridge003,
HaiShaw,
Qiaolin-Yu,
hebiao064,
ispobock and
merrymercy
as code owners
September 28, 2026 01:57
4 of 5 tasks
HaiShaw
approved these changes
Sep 30, 2026
Collaborator
Author
|
/rerun-failed-ci |
4 of 5 tasks
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MiniMax-M3 fails to start with EAGLE3 on ROCm because target verification expects missing prefill metadata. This PR adds the missing verify path.
Modifications
--speculative-eagle-topk 1), with the correct causal KV length for each token.Accuracy Tests
amd/MiniMax-M3-MXFP4, full 5-shot GSM8K, chat-completions, 16384-token output budget, temperature 0, and real EAGLE3 verification. Results are as expected.Benchmarking and Profiling
AgentX on MI355X, TP4/EP1, C1 and C32, no KV offload, 3600 seconds per run, the baseline uses standard decoding and the fixed run enables EAGLE3.
C1:
C32:
Checklist
CI States
Latest PR Test (Base): ✅ Run #36686661208
Latest PR Test (Extra): ❌ Run #36686660506
Latest PR Test (AMD ROCm 10): ⏳ Run #36686661067