Repository navigation
[HiCache] refactor: retire in-flight storage prefetches through one helper - #41453
Merged
ispobock merged 6 commits intoOct 4, 2026
Merged
Conversation
alphabetc1
requested review from
Ying1123,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
September 27, 2026 13:36
ispobock
approved these changes
Oct 4, 2026
alphabetc1
enabled auto-merge (squash)
October 4, 2026 16:10
ispobock
disabled auto-merge
October 4, 2026 16:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dropping an in-flight storage prefetch was written four times:
release_aborted_request, the all-or-nothing discard in_check_hybrid_prefetch_result,revoke_pending_prefetch, andStorageAttachment._release_pending_storage_ops. Each releases the anchor host lock, the buffer-mode prefix context and anchor, the host pages, and the prefetch occupancy, and they had already drifted (two clampprefetch_tokens_occupiedat 0, two do not).Modifications
_retire_ongoing_prefetch(request, host_indices, extra_pools)and route all four through it. What each caller releases (the completed prefix, the aux pools, whetherpool_transfers_donegates them) is passed in unchanged._check_hybrid_prefetch_resultloses four parameters it no longer needs.Accuracy Tests
test/registered/unit/{mem_cache,disaggregation,managers}and the Rust-core run of the shared suite: same results as main. The mock-based storage-cleanup test now wires the new helper like it already wires_prefetch_occupied_span.Checklist
CI States
Latest PR Test (Base): ⏳ Run #37202314137
Latest PR Test (Extra): ❌ Run #37202313945
Latest PR Test (AMD ROCm 10): ❌ Run #37202314347