Conversation
zhyncs
reviewed
Mar 6, 2025
| /python/sglang/srt/models @merrymercy @Ying1123 @hnyls2002 @zhyncs @ispobock @ByronHsu | ||
| /python/sglang/srt/openai_api @merrymercy @Ying1123 @hnyls2002 @zhyncs @ispobock @ByronHsu | ||
| /python/sglang/srt/sampling @merrymercy @hnyls2002 | ||
| /python/sglang/srt/speculative @Ying1123 @merrymercy @rkooo567 @kssteven418 |
Collaborator
There was a problem hiding this comment.
Can we give write permission to these two authors, or else we will encounter an error?
CODEOWNERS errors
Unknown owner on line 12: make sure @rkooo567 exists and has write access to the repository
Contributor
Author
There was a problem hiding this comment.
I have sent the invite.
aoshen524
pushed a commit
to aoshen524/sglang
that referenced
this pull request
Mar 10, 2025
Co-authored-by: SangBin Cho <rkooo567@gmail.com> Co-authored-by: Sehoon Kim <kssteven418@gmail.com> Co-authored-by: Lianmin Zheng <lianminzheng@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also intends to add credits back to the following PR #3986