Add test for Radix cache variants#4125
Closed
Edenzzzz wants to merge 12 commits intosgl-project:mainfrom
Closed
Conversation
Collaborator
|
Can you check all the code? |
Collaborator
|
Also please add test for it. |
zhyncs
suggested changes
Mar 6, 2025
Collaborator
zhyncs
left a comment
There was a problem hiding this comment.
This change is wrong https://github.com/sgl-project/sglang/actions/runs/13691250535/job/38284792114?pr=4125 Can you test locally by yourself?
Contributor
Author
Contributor
Author
|
@zhyncs Should we also test evict? It seems to happen at very high request rates, not sure how many requests are needed |
Collaborator
Contributor
Author
|
@zhaochenyang20 Added |
Contributor
|
This pull request has been automatically closed due to inactivity. Please feel free to reopen it if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add test to ensure radix cache functionalities are complete and runnable after refactors such as #3986
Modifications
Checklist