Skip to content

Add test for Radix cache variants#4125

Closed
Edenzzzz wants to merge 12 commits intosgl-project:mainfrom
Edenzzzz:fix_pool
Closed

Add test for Radix cache variants#4125
Edenzzzz wants to merge 12 commits intosgl-project:mainfrom
Edenzzzz:fix_pool

Conversation

@Edenzzzz
Copy link
Copy Markdown
Contributor

@Edenzzzz Edenzzzz commented Mar 6, 2025

Motivation

Add test to ensure radix cache functionalities are complete and runnable after refactors such as #3986

Modifications

Checklist

@Edenzzzz Edenzzzz changed the title Fix pool [Hotfix] Fix incomplete refactor for cache args Mar 6, 2025
@zhyncs
Copy link
Copy Markdown
Collaborator

zhyncs commented Mar 6, 2025

Can you check all the code?

@zhyncs
Copy link
Copy Markdown
Collaborator

zhyncs commented Mar 6, 2025

Also please add test for it.

Copy link
Copy Markdown
Collaborator

@zhyncs zhyncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Mar 6, 2025

@zhyncs Sure, I will add a test with @xihuai18 that tests if different args for the cache are runnable

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Mar 6, 2025

@zhyncs Should we also test evict? It seems to happen at very high request rates, not sure how many requests are needed

@Edenzzzz Edenzzzz changed the title [Hotfix] Fix incomplete refactor for cache args Add test for Radix cache variants Mar 6, 2025
@zhaochenyang20
Copy link
Copy Markdown
Collaborator

@Edenzzzz I am good with the tests. But, add it in the run suites. @Edenzzzz

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Mar 7, 2025

@zhaochenyang20 Added

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity. Please feel free to reopen it if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants