Skip to content

[Hoxfix] Fix incomplete token_to_kv_pool refactor#4121

Merged
zhaochenyang20 merged 1 commit intosgl-project:mainfrom
Edenzzzz:fix_pool
Mar 6, 2025
Merged

[Hoxfix] Fix incomplete token_to_kv_pool refactor#4121
zhaochenyang20 merged 1 commit intosgl-project:mainfrom
Edenzzzz:fix_pool

Conversation

@Edenzzzz
Copy link
Copy Markdown
Contributor

@Edenzzzz Edenzzzz commented Mar 6, 2025

Motivation

Two references are not renamed in #3986, causing runtime error.

Modifications

Checklist

@Edenzzzz
Copy link
Copy Markdown
Contributor Author

Edenzzzz commented Mar 6, 2025

cc @zhyncs @zhaochenyang20

@Edenzzzz Edenzzzz changed the title [Hoxfix] Incomplete token_to_kv_pool refactor [Hoxfix] Fix incomplete token_to_kv_pool refactor Mar 6, 2025
@zhaochenyang20 zhaochenyang20 merged commit 718c391 into sgl-project:main Mar 6, 2025
3 of 18 checks passed
@Edenzzzz Edenzzzz deleted the fix_pool branch March 6, 2025 03:43
@zhyncs
Copy link
Copy Markdown
Collaborator

zhyncs commented Mar 6, 2025

@Edenzzzz May you help add a test for it? Thanks.

aoshen524 pushed a commit to aoshen524/sglang that referenced this pull request Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants