Repository navigation
Conversation
ispobock
requested review from
Ying1123,
alphabetc1,
hanming-lu,
hnyls2002,
huangtingwei9988,
hzh0425,
merrymercy,
xiezhq-hermann and
yizhang2077
as code owners
September 23, 2026 13:04
This was referenced Sep 23, 2026
ispobock
force-pushed
the
hicache-decl-a
branch
from
September 23, 2026 13:25
76d3e21 to
526e888
Compare
ispobock
force-pushed
the
hicache-decl-b
branch
from
September 23, 2026 13:25
1270033 to
4bcb754
Compare
ispobock
force-pushed
the
hicache-decl-a
branch
from
September 28, 2026 12:46
526e888 to
44bd2ac
Compare
2 tasks done
ispobock
force-pushed
the
hicache-decl-b
branch
from
October 1, 2026 08:55
4bcb754 to
5730ea4
Compare
ispobock
added
run-ci
ispobock
requested review from
Jialin,
Jiminator,
Qiaolin-Yu,
fzyzcjy,
kpham-sgl and
pyc96
as code owners
October 5, 2026 11:23
ispobock
requested review from
AgainstEntropy,
ByronHsu,
CatherineSue,
ClawSeven,
DarkSharpness,
Duyi-Wang,
HydraQYH,
JustinTong0323,
Lzy17,
ShangmingCai,
YAMY1234,
billishyahao,
celve,
hebiao064,
iforgetmyname,
ishandhanani,
kevin-mii,
mickqian,
niehen6174,
ping1jing2,
rainj-me,
rwang5203,
slin1237,
sogalin,
whybeyoung,
wisclmy0611,
yuan-luo and
zijiexia
as code owners
October 5, 2026 11:23
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Part 2 of 5 of #40608. The separate (non packed) draft path in build_full_draft_pools still picks the DSA indexer by isinstance. A draft pool's declarations are now renamed into the target's sidecar namespace (KV to DRAFT, INDEXER to DRAFT_INDEXER, indices from target KV, layout on DRAFT) and assembled by the same builder as the target. Hybrid Mamba, QSA and plain KV keep their existing paths.
Stack: #40913 (declarations and DSA target), #40914 (separate draft), #40915 (hybrid Mamba), #40916 (QSA), #40917 (plain KV and cleanup). Each PR is based on the previous one.
Accuracy
Structure tests pin the DRAFT and DRAFT_INDEXER entries, their layer mapping and geometry, and that a draft without index buffers gets no indexer sidecar. No DSA family standalone draft model is available, so this path is CPU tested only, as it was before.
CI States
Latest PR Test (Base): ❌ Run #37405381419
Latest PR Test (Extra): 🚫 Run #37405381225
Latest PR Test (AMD ROCm 10): ❌ Run #37405381351