Skip to content

[PD] Simplify late-abort quiescent ack branch to else #40711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShangmingCai merged 3 commits into from
Sep 22, 2026
Merged

[PD] Simplify late-abort quiescent ack branch to else #40711

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83406b6
Fix PD abort acknowledgments racing sender cleanup
cctry Sep 21, 2026
4ac5d7b
[PD] Simplify late-abort quiescent ack branch to else
ShangmingCai Sep 22, 2026
ec58dba
Merge branch 'main' into shangming/pd-abort-ack-else-cleanup
ShangmingCai Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions python/sglang/srt/disaggregation/mooncake/conn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2485,10 +2485,10 @@ def bootstrap_thread():
f"Received abort notification for room {room_to_be_aborted}, "
f"marked as Failed; ACK deferred until transfer drains"
)
elif self._staging_outstanding.get(room_to_be_aborted, 0) == 0:
# Concluded/unknown AND quiescent: ack now. A cleared
# room is not automatically quiescent -- clear() can
# drop a room whose chunk is still transferring.
else:
# Concluded/unknown AND quiescent (the branch above
# already took every case with writes outstanding):
# ack now so decode releases without the timeout.
self._send_abort_ack(
decode_ip, decode_port, room_to_be_aborted
)
Expand Down
Loading