Repository navigation
Conversation
McZyWu
requested review from
BBuf,
Edwardf0t1,
Fridge003,
HaiShaw,
Ying1123,
ch-wan,
ispobock and
merrymercy
as code owners
September 21, 2026 06:51
sglang-npu-bot
approved these changes
Sep 21, 2026
Collaborator
|
/tag-and-rerun-ci |
Contributor
Author
|
/rerun-failed-ci |
1 similar comment
Contributor
Author
|
/rerun-failed-ci |
sglang-npu-bot
approved these changes
Sep 28, 2026
sglang-npu-bot
approved these changes
Sep 29, 2026
Contributor
Author
|
/rerun-failed-ci |
1 similar comment
Contributor
Author
|
/rerun-failed-ci |
Contributor
Author
|
/rerun-failed-ci |
2 similar comments
Contributor
Author
|
/rerun-failed-ci |
Contributor
Author
|
/rerun-failed-ci |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
W8A8 MoE inference with DeepEP fails on Ascend A5 with
x=DT_FLOAT8_E4M3FN, weight=DT_INT8inaclnnGroupedMatmulWeightNz. Both an explicit--deepep-dispatcher-output-dtype int8andautoresolved from the W8A8 quantization config map touse_fp8=True. DeepEP resolves this flag to INT8 on A3, but to per-token FP8 on A5. The flag also takes precedence over the normal-modeDEEP_NORMAL_MODE_USE_INT8_QUANT=1fallback.Modifications
Disable
use_fp8only for INT8 dispatcher requests on NPU arch35. Normal dispatch can then use its existing INT8 environment fallback; otherwise BF16 activations are dispatched and the existing MoE quantizer converts them to INT8 before grouped matmul. Low-latency dispatch uses the same BF16 fallback. A3 and explicit FP8/MXFP8/MXFP4 requests retain their existing behavior.The change is limited to 9 added lines in one file.
Accuracy Tests
auto/INT8/BF16/FP8 and A5 MXFP8/MXFP4, and normal-mode INT8 environment values 0/1. Both normal and low-latency routing are checked. The harness reproduces FP8 selection for the failing A5 INT8 requests before this change.F401,F821,UP037), Ruff format check, andgit diff --check.test_npu_deepep_dispatcher_output_dtype.pyregression have not been run. The local harness does not validate numerical accuracy or NPU kernels.Speed Tests and Profiling
Not run. The A5 BF16 fallback increases dispatch payload size relative to INT8 and adds local dynamic quantization. Normal dispatch with
DEEP_NORMAL_MODE_USE_INT8_QUANT=1retains INT8 dispatch. This is a minimal compatibility fix; it does not add an explicit A5 low-latency INT8 dispatch API.Checklist
CI States
Latest PR Test (Base): ❌ Run #36688522900
Latest PR Test (Extra): ❌ Run #36688522313
Latest PR Test (AMD ROCm 10): ❌ Run #36688522915