Repository navigation
Enrich chat_parsing streaming events #40478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yonigozlan
wants to merge
16
commits into
sgl-project:main
Choose a base branch
from
yonigozlan:feat/chat-parsing-events
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+217
−41
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9b20eb9
Port chat_parsing core
yonigozlan 2295531
Keep already-decoded array arguments unchanged.
yonigozlan 59a3c48
Fix mutable template defaults leaking across parsers
JustinTong0323 75fc072
Enrich response parser streaming events
yonigozlan 2af08ac
Simplify response region close offsets
yonigozlan 6a463a0
Clarify response region close handling
yonigozlan 5bb1485
Trim response event contract tests
yonigozlan b2d9a1e
Drop copied response event fields and xml-inline strict mode.
yonigozlan 9aa9c1a
Simplify chat_parsing streaming events
yonigozlan 261ec8a
Keep held-back prompt bytes out of streamed region chunks
yonigozlan 106b751
Raise for malformed regions produced by the prompt prefix
yonigozlan 30546df
Merge main into feat/chat-parsing-events
Jiminator 5ef3746
Fix chat parsing event contracts and error recovery
Jiminator 0bb6c88
Merge branch 'main' into feat/chat-parsing-events
Jiminator 499c3bd
Merge branch 'main' into feat/chat-parsing-events
Jiminator 5e781f7
Merge branch 'main' into feat/chat-parsing-events
Jiminator File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RecursionErrorescapes this handler — a region body with deep nesting ('[' * 20000) aborts the whole stream instead of recovering (same through_coercevia the JSON content parser). Convert it toValueErrorat the decode boundary so recover-and-continue holds.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed