Skip to content

[Fix] Forward SWA prealloc reclaim through the DSV4 HiSparse allocator - #40354

Merged
ch-wan merged 1 commit into
mainfrom
mmangkad/fix-hisparse-prealloc-reclaim
Sep 20, 2026
Merged

ch-wan merged 1 commit into
mainfrom
mmangkad/fix-hisparse-prealloc-reclaim

Conversation

@mmangkad

@mmangkad mmangkad commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

#39477 moved the decode-node SWA prealloc reclaim behind a new reclaim_for_prealloc allocator method, but DeepSeekV4HiSparseTokenToKVPoolAllocator wraps a SWA allocator rather than being one and hand-delegates each SWA method, so it never got one and every TP rank died with an AttributeError on the first admitted request. Delegate it to logical_attn_allocator and add a CPU regression case.

SGLANG_IS_IN_CI=true python test/registered/disaggregation/test_disaggregation_hisparse.py

Total latency: 15.536 s
Score: 0.960
Output throughput: 1199.603 token/s

Ran 2 tests in 154.649s

OK (skipped=1)

CI States

Latest PR Test (Base): ❌ Run #35445270465
Latest PR Test (Extra): ❌ Run #35445270148
Latest PR Test (AMD ROCm 10): ❌ Run #35445270461

@mmangkad

Copy link
Copy Markdown
Collaborator Author

/rerun-test test/registered/disaggregation/test_disaggregation_hisparse.py test/registered/unit/mem_cache/test_hisparse_allocator.py

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Results for /rerun-test test/registered/disaggregation/test_disaggregation_hisparse.py test/registered/unit/mem_cache/test_hisparse_allocator.py:

🚀 8-gpu-h200 (1 test): ✅ View workflow run

cd test/ && python3 registered/disaggregation/test_disaggregation_hisparse.py

🚀 ubuntu-latest (1 test): ✅ View workflow run

cd test/ && python3 registered/unit/mem_cache/test_hisparse_allocator.py

@ch-wan
ch-wan merged commit df0dc44 into main Sep 20, 2026
111 of 127 checks passed
@ch-wan
ch-wan deleted the mmangkad/fix-hisparse-prealloc-reclaim branch September 20, 2026 03:27
cctry pushed a commit that referenced this pull request Sep 21, 2026
#40354)

Co-authored-by: Mohammad Angkad <mohammad.angkad@radixark.ai>
(cherry picked from commit df0dc44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants