Repository navigation
[Fix] Forward SWA prealloc reclaim through the DSV4 HiSparse allocator - #40354
Merged
Merged
Conversation
mmangkad
requested review from
alphabetc1,
hnyls2002,
huangtingwei9988,
hzh0425,
ispobock and
xiezhq-hermann
as code owners
September 19, 2026 13:16
Collaborator
Author
|
/rerun-test test/registered/disaggregation/test_disaggregation_hisparse.py test/registered/unit/mem_cache/test_hisparse_allocator.py |
Contributor
|
Results for 🚀 🚀 |
ch-wan
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#39477 moved the decode-node SWA prealloc reclaim behind a new
reclaim_for_preallocallocator method, butDeepSeekV4HiSparseTokenToKVPoolAllocatorwraps a SWA allocator rather than being one and hand-delegates each SWA method, so it never got one and every TP rank died with anAttributeErroron the first admitted request. Delegate it tological_attn_allocatorand add a CPU regression case.CI States
Latest PR Test (Base): ❌ Run #35445270465
Latest PR Test (Extra): ❌ Run #35445270148
Latest PR Test (AMD ROCm 10): ❌ Run #35445270461