Repository navigation
Conversation
Register the unified handout zeroing unit test in the AMD 1-GPU suite. This exercises the ROCm Triton allocator and page-zeroing path with a 9-second estimate.
HaiShaw
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Register
test_unified_handout_zeroing.pyinstage-b-test-1-gpu-small-amd.The test exercises the unified allocator and page-zeroing kernels on device memory. On AMD this lowers through ROCm Triton, covering backend-specific code generation and launch behavior while checking that fresh and recycled page envelopes are zeroed.
The AMD small suite grows from 108 to 109 effective entries (+9 estimated GPU-seconds).
Test plan
sanity_check=Truetest_unified_handout_zeroing.pypassed; partition 3 finished 7/7 (job)The overall AMD run also has an unrelated MI35x failure in
test_quark_mxfp4.py: GSM8K accuracy was 0.826, below the required 0.85 (job).CI States
Latest PR Test (Base): 🚫 Run #35676915009
Latest PR Test (Extra): ❌ Run #35676914878
Latest PR Test (AMD ROCm 10): ⏳ Run #35676914989