Simplify lm head in eagle#4002
Closed
zhaochenyang20 wants to merge 22 commits intosgl-project:mainfrom
Closed
Conversation
support download token-map from hf and fix docs
zhaochenyang20
requested review from
ByronHsu,
Ying1123,
hnyls2002,
ispobock,
merrymercy and
zhyncs
as code owners
Collaborator
|
Why created a new PR? |
6 tasks
Collaborator
|
You can just push to that PR directly |
Collaborator
Author
|
@zhyncs I by passed it and fixed it locally. |
Collaborator
|
I don’t think that we need to use a new PR |
Collaborator
|
May we close this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
By pass this PR by fix lint, CI and docs.
#3822
Modifications
Checklist