Repository navigation
[Test] Consolidate kernel tests under plural kernels tree - #39966
Merged
Merged
Conversation
BBuf
requested review from
AgainstEntropy,
Fridge003,
HaiShaw,
Kangyan-Zhou,
bingxche,
ch-wan,
ispobock,
merrymercy,
mickqian,
ping1jing2,
yichiche and
yizhang2077
as code owners
September 17, 2026 12:43
github-actions
Bot
added
documentation
4 of 5 tasks
mrusanovsky
added a commit
to mrusanovsky/sglang
that referenced
this pull request
Sep 18, 2026
Review feedback from kpham-sgl. Comment style, per .claude/rules/comment-style.md. Docstrings and comments in the non-test source drop from 479 lines to 310 across 1,928: the multi-line rationale blocks go (that material belongs in the PR body, the docs section, or git log) and what stays is the tensor shape contracts, the provenance of the measured constants, and the two correctness arguments a reader cannot recover from the code -- the tiled top-k's exactness proof and why a greedy row must report a point mass. Test docstrings are one or two lines each, as the rule's bug-regression case allows. The docs subsection loses a third of its prose and is now proportional to the DFlash section above it. Two internal-workflow references that should never have shipped are gone with it. One module. lilicorr_components/ (four files, 933 lines) becomes srt/speculative/lilicorr_utils.py, matching the flat dflash_utils.py / domino_utils.py naming beside it. Pure code movement, no behaviour change: 46 CPU, 11 worker-stub and 18 GPU kernel-parity tests pass unchanged on an H100. Tests in the kind/subsystem taxonomy. Upstream sgl-project#39966 renamed the kernel tree to test/registered/kernels/{ops,benchmark}/<group>/, which left test_lilicorr_cuda.py on a path check_registered_tests.py now rejects -- it moves beside test_verify_commit_triton.py. The E2E server test moves to extra-b as asked. The kernel-parity test cannot follow it: the taxonomy check requires a *-kernel-* suite for anything under kernels/, and extra-b has no kernel suite. It stays on base-b-kernel-unit-test-1-gpu-large. Also moves the `if __name__ == "__main__"` block in both test files to the end; the sampling commit had appended cases after it.
lorr1
pushed a commit
to lorr1/sglang
that referenced
this pull request
Sep 18, 2026
Upstream sgl-project#39966 consolidated kernel tests under test/registered/kernels/ and dropped "kernel" from the valid test kinds in scripts/lint/check_registered_tests.py, so move the BF16 absorb kernel test to test/registered/kernels/ops/attention/. Its jit-kernel-unit-test-amd suite already carries the *-kernel-* infix the new rule requires. The GLM-5.2 cookbook conflict is textual. Upstream bumped the MTP image tag and dropped a sentence from the bullet the hybrid absorb bullet follows; keep the upstream wording and the added bullet. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
kpham-sgl
added a commit
that referenced
this pull request
Sep 21, 2026
Resolves the rename conflict from #39966 by moving the new test to test/registered/kernels/ops/attention/. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
kevin-mii
added a commit
to kevin-mii/sglang
that referenced
this pull request
Sep 23, 2026
Main moved kernel tests under test/registered/kernels/ops (sgl-project#39966), renamed wo_a_bf16.py to wo_a.py (sgl-project#39957) and moved the low-ratio page-table expansion into dsv4/candidate_indexer.py (sgl-project#40352). Place the remaining AMD suites in the plural tree and follow the two renames. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
test/registered/currently has three kernel-test roots: the established pluralkernels/tree, a newer singularkernel/tree, and a few remaining files underjit/. This makes placement ambiguous and allows the same class of tests to drift across parallel layouts.Changes
test/registered/kernel/intotest/registered/kernels/ops/<group>/ortest/registered/kernels/benchmark/<group>/.test/registered/jit/tests into the same plural tree.test/registered/kernels/{ops,benchmark}/<group>/and a*-kernel-*suite.Validation
python3 scripts/lint/check_registered_tests.pypython3 scripts/lint/check_no_registered_tests_in_package.pypython3 -m unittest discover -s scripts/lint -p 'test_check_*.py'pre-commit run --files <all changed files>uv run --with pyyaml python scripts/lint/check_workflow_job_names.pygit diff --checkCI States
Latest PR Test (Base): 🚫 Run #35222788191
Latest PR Test (Extra): ❌ Run #35222822497
Latest PR Test (AMD ROCm 10): ❌ Run #35222787977